Skip to content

Remove api prefix from update_job_permission in databricks hook #53039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Jul 21, 2025
Merged

Remove api prefix from update_job_permission in databricks hook #53039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01d2778
Remove `api` prepend from update_job_permission
fjmacagno Jul 8, 2025
cd471d2
Merge branch 'apache:main' into patch-1
fjmacagno Jul 21, 2025
520cdcc
Add test for update_job_permission hostname
fjmacagno Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/databricks/src/airflow/providers/databricks/hooks/databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ def update_job_permission(self, job_id: int, json: dict[str, Any]) -> dict:
:param json: payload
:return: json containing permission specification
"""
return self._do_api_call(("PATCH", f"api/2.0/permissions/jobs/{job_id}"), json)
return self._do_api_call(("PATCH", f"2.0/permissions/jobs/{job_id}"), json)

def post_sql_statement(self, json: dict[str, Any]) -> str:
"""
Expand Down
23 changes: 23 additions & 0 deletions providers/databricks/tests/unit/databricks/hooks/test_databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
TOKEN_REFRESH_LEAD_TIME,
BearerAuth,
)
from airflow.providers.databricks.utils import databricks as utils

TASK_ID = "databricks-operator"
DEFAULT_CONN_ID = "databricks_default"
Expand Down Expand Up @@ -130,6 +131,10 @@
{"key": "8.2.x-scala2.12", "name": "8.2 (includes Apache Spark 3.1.1, Scala 2.12)"},
]
}
ACCESS_CONTROL_DICT = {
"user_name": "jsmith@example.com",
"permission_level": "CAN_MANAGE",
}


def create_endpoint(host):
Expand Down Expand Up @@ -1248,6 +1253,24 @@ def test_connection_failure(self, mock_requests):
timeout=self.hook.timeout_seconds,
)

@mock.patch("airflow.providers.databricks.hooks.databricks_base.requests")
def test_update_job_permission(self, mock_requests):
mock_requests.codes.ok = 200
mock_requests.patch.return_value.json.return_value = {}
status_code_mock = mock.PropertyMock(return_value=200)
type(mock_requests.patch.return_value).status_code = status_code_mock

self.hook.update_job_permission(1, ACCESS_CONTROL_DICT)

mock_requests.patch.assert_called_once_with(
f"https://{HOST}/api/2.0/permissions/jobs/1",
json=utils.normalise_json_content(ACCESS_CONTROL_DICT),
params=None,
auth=HTTPBasicAuth(LOGIN, PASSWORD),
headers=self.hook.user_agent_header,
timeout=self.hook.timeout_seconds,
)


@pytest.mark.db_test
class TestDatabricksHookToken:
Expand Down