Skip to content

Remove set_current_context from airflow.models.taskinstance #53036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Jul 8, 2025
Merged

Remove set_current_context from airflow.models.taskinstance #53036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions airflow-core/src/airflow/models/taskinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import os
import uuid
from collections import defaultdict
from collections.abc import Collection, Generator, Iterable
from collections.abc import Collection, Iterable
from datetime import timedelta
from functools import cache
from typing import TYPE_CHECKING, Any
Expand Down Expand Up @@ -156,28 +156,6 @@ def _add_log(
)


@contextlib.contextmanager
def set_current_context(context: Context) -> Generator[Context, None, None]:
"""
Set the current execution context to the provided context object.

This method should be called once per Task execution, before calling operator.execute.
"""
from airflow.sdk.definitions._internal.contextmanager import _CURRENT_CONTEXT

_CURRENT_CONTEXT.append(context)
try:
yield context
finally:
expected_state = _CURRENT_CONTEXT.pop()
if expected_state != context:
log.warning(
"Current context is not equal to the state at context stack. Expected=%s, got=%s",
context,
expected_state,
)


def _stop_remaining_tasks(*, task_instance: TaskInstance, task_teardown_map=None, session: Session):
"""
Stop non-teardown tasks in dag.
Expand Down
5 changes: 4 additions & 1 deletion providers/standard/tests/unit/standard/operators/test_python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
DeserializingResultError,
)
from airflow.models.connection import Connection
from airflow.models.taskinstance import TaskInstance, clear_task_instances, set_current_context
from airflow.models.taskinstance import TaskInstance, clear_task_instances
from airflow.providers.standard.operators.empty import EmptyOperator
from airflow.providers.standard.operators.python import (
BranchExternalPythonOperator,
Expand All @@ -74,8 +74,11 @@

if AIRFLOW_V_3_0_PLUS:
from airflow.sdk import BaseOperator
from airflow.sdk.execution_time.context import set_current_context
else:
from airflow.models.baseoperator import BaseOperator # type: ignore[no-redef]
from airflow.models.taskinstance import set_current_context # type: ignore[attr-defined,no-redef]


if TYPE_CHECKING:
from airflow.models.dag import DAG
Expand Down