Handle S3KeySensor in deferrable mode splits bucket_key into individual chars
#52983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
2 tasks
dominikhei
reviewed
Jul 7, 2025
Contributor
dominikhei
left a comment
dominikhei
left a comment
There was a problem hiding this comment.
Can you add tests to check list inputs to get_files_async too?
Contributor
I agree |
Collaborator
Author
|
I'll add those tests - thanks all! |
o-nikolas
reviewed
Jul 7, 2025
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
This issue is so bizarre. I'm curious how we went so long without noticing. Thanks for catching it!
+1 to adding tests
vincbeck
approved these changes
Jul 7, 2025
dominikhei
approved these changes
Jul 7, 2025
o-nikolas
approved these changes
Jul 7, 2025
Collaborator
Author
|
@vincbeck, do you mind merging this? |
eladkal
approved these changes
Jul 8, 2025
17 tasks
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Jul 10, 2025
…dividual chars (apache#52983) * Handle S3KeySensor in deferrable mode splits key into individual chars * Adding tests for passing keys as a list
stephen-bracken
pushed a commit
to stephen-bracken/airflow
that referenced
this pull request
Jul 15, 2025
…dividual chars (apache#52983) * Handle S3KeySensor in deferrable mode splits key into individual chars * Adding tests for passing keys as a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #52920, using the
S3KeySensorin deferrable mode split thebucket_keyparameter into individual characters when passing a string. This PR aims to resolve this by first checking ifbucket_keyis a string, before handling that behavior.Note that two tests were updated as part of this PR. It appears, in fact, that these tests were written to accommodate this faulty logic. This has been fixed.
Closes: #52920