-
Notifications
You must be signed in to change notification settings - Fork 16.4k
fix: Change DataprocAsyncHook parent class to GoogleBaseAsyncHook #52981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I’m updating the test codes. |
|
@RNHTTR Hi there! Could you pls review my pr when you have time? |
RNHTTR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small nits. Also... should there be a test for get_cluster?
|
@eladkal I got approved. Could you please merge this pr? cause this is related to another issue! |
|
@kgw7401 I think that this is nice pr. but if one morething to be added, it is nice pr more. in test_dataproc.py @pytest.fixture
def async_get_operation():
def func(**kwargs):
m = mock.MagicMock()
m.configure_mock(**kwargs)
f = Future()
f.set_result(m)
return f
return funcit should be removed. because that fixture is not being used in that module. |
Could be separate PR. |
|
We try to focus on one thing only in one PR - this is super important for cherry-picking/reverting / tracking what was changed when |
Hi I'm making some feature on dataproc trigger but i got an error related to async when i set
deferrable=TrueHere is error that i encountered.
Related: #52005
I think main reason is that even if i use get_async_hook, inside of DataprocAsyncHook inherit GoogleBaseHook that is not for async. so i change the DataprocAsyncHook's parent class into GoogleBaseAsyncHook.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.