Skip to content

Remove MAX_XCOM_SIZE hardcoded constant from Airflow core #52978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 2 commits into from
Jul 7, 2025
Merged

Remove MAX_XCOM_SIZE hardcoded constant from Airflow core #52978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f12218
Remove usages of MAX_XCOM_SIZE in providers precursor to wiping it off
amoghrajesh Jul 7, 2025
038ee80
Nuke MAX_XCOM_SIZE
amoghrajesh Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion airflow-core/src/airflow/models/xcom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
# XCom constants below are needed for providers backward compatibility,
# which should import the constants directly after apache-airflow>=2.6.0
from airflow.utils.xcom import (
MAX_XCOM_SIZE, # noqa: F401
XCOM_RETURN_KEY,
)

Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/utils/xcom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,4 @@
# https://github.com/apache/airflow/pull/1618#discussion_r68249677
from __future__ import annotations

MAX_XCOM_SIZE = 49344
XCOM_RETURN_KEY = "return_value"
6 changes: 5 additions & 1 deletion providers/amazon/src/airflow/providers/amazon/aws/transfers/google_api_to_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from collections.abc import Sequence
from typing import TYPE_CHECKING

from airflow.models.xcom import MAX_XCOM_SIZE, XCOM_RETURN_KEY
from airflow.models.xcom import XCOM_RETURN_KEY
from airflow.providers.amazon.aws.hooks.s3 import S3Hook
from airflow.providers.amazon.version_compat import BaseOperator
from airflow.providers.google.common.hooks.discovery_api import GoogleDiscoveryApiHook
Expand All @@ -36,6 +36,10 @@
from airflow.models import TaskInstance as RuntimeTaskInstanceProtocol # type: ignore[assignment]
from airflow.utils.context import Context

# MAX XCOM Size is 48KB
# https://github.com/apache/airflow/pull/1618#discussion_r68249677
MAX_XCOM_SIZE = 49344


class GoogleApiToS3Operator(BaseOperator):
"""
Expand Down
3 changes: 1 addition & 2 deletions providers/amazon/tests/unit/amazon/aws/transfers/test_google_api_to_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
import pytest

from airflow import models
from airflow.models.xcom import MAX_XCOM_SIZE
from airflow.providers.amazon.aws.transfers.google_api_to_s3 import GoogleApiToS3Operator
from airflow.providers.amazon.aws.transfers.google_api_to_s3 import MAX_XCOM_SIZE, GoogleApiToS3Operator

# This test mocks json.dumps so it won't work for database isolation mode

Expand Down
4 changes: 3 additions & 1 deletion providers/google/src/airflow/providers/google/cloud/transfers/gcs_to_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@
from typing import TYPE_CHECKING

from airflow.exceptions import AirflowException
from airflow.models.xcom import MAX_XCOM_SIZE
from airflow.providers.google.cloud.hooks.gcs import GCSHook
from airflow.providers.google.version_compat import BaseOperator

if TYPE_CHECKING:
from airflow.utils.context import Context

# MAX XCOM Size is 48KB, check discussion: https://github.com/apache/airflow/pull/1618#discussion_r68249677
MAX_XCOM_SIZE = 49344


class GCSToLocalFilesystemOperator(BaseOperator):
"""
Expand Down
3 changes: 1 addition & 2 deletions providers/google/tests/unit/google/cloud/transfers/test_gcs_to_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
import pytest

from airflow.exceptions import AirflowException
from airflow.models.xcom import MAX_XCOM_SIZE
from airflow.providers.google.cloud.transfers.gcs_to_local import GCSToLocalFilesystemOperator
from airflow.providers.google.cloud.transfers.gcs_to_local import MAX_XCOM_SIZE, GCSToLocalFilesystemOperator

TASK_ID = "test-gcs-operator"
TEST_BUCKET = "test-bucket"
Expand Down