fix: always create GitHook even when repo_url is provided
#52897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #52332
Why
A corner case in
GitDagBundlecauses pulling DAGs from a private GitHub repository to fail wheneverrepo_urlis set indag_bundle_config_list.How
Move the
try / exceptblock before therepo_urldetection so that the GitHook is always created.What
I tested with a private repo and created an example DAG:
Bundle configuration
dag_bundle_config_list = [{"name": "dags-folder", "classpath": "airflow.providers.git.bundles.git.GitDagBundle", "kwargs": {"repo_url": "git@github.com:nailo2c/my_repo.git" , "tracking_ref": "main", "subdir": "dags"}}]Git connection
It works well
