Skip to content

Replace BaseHook to Task SDK for apache/tinkerpop #52844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 2 commits into from
Jul 5, 2025
Merged

Replace BaseHook to Task SDK for apache/tinkerpop #52844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538cdbd
Replace BaseHook to Task SDK for apache/tinkerpop
bdsoha Jul 4, 2025
d1f4626
Merge branch 'main' into feature/migrate-tinkerpop-to-sdk
bdsoha Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions providers/apache/tinkerpop/src/airflow/providers/apache/tinkerpop/hooks/gremlin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@

from gremlin_python.driver.client import Client

try:
from airflow.sdk import BaseHook
except ImportError:
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]
from airflow.providers.apache.tinkerpop.version_compat import BaseHook

if TYPE_CHECKING:
from airflow.models import Connection
Expand Down
13 changes: 11 additions & 2 deletions providers/apache/tinkerpop/src/airflow/providers/apache/tinkerpop/version_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

from __future__ import annotations


Expand All @@ -28,10 +27,20 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:


AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)
AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0)

if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import BaseHook
else:
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]

if AIRFLOW_V_3_0_PLUS:
from airflow.sdk import BaseOperator
else:
from airflow.models import BaseOperator

__all__ = ["AIRFLOW_V_3_0_PLUS", "BaseOperator"]
__all__ = [
"AIRFLOW_V_3_0_PLUS",
"BaseHook",
"BaseOperator",
]