[FEATURE] Added response validation in HttpToGcsOperator #52738
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
josuegen
changed the title
VladaZakharova
suggested changes
Jul 3, 2025
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| from airflow.providers.google.cloud.transfers.http_to_gcs import HttpToGCSOperator | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Can you please add unit tests to cover the functionality you have introduced? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a small feature from the conversation in this PR.
Initially the
docstringin the operator mentioned that there were two arguments available:response_check(callable)response_filter(callable)Which later I chose not to include them in the first released version of the operator.
Now I'm including the functionality to check the HTTP response before writing the data into GCS