Skip to content

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jul 2, 2025

When a user sets an external_view to have a category that matches one of our existing menus in the Nav bar (Admin, Browse, User, and Docs). We add it to that menu.

  • fixed how plugin icons render in a menu
  • Added an external icon to make it clear which Nav buttons will show pages vs open a new tab
Screenshot 2025-07-02 at 3 50 54 PM Screenshot 2025-07-02 at 3 51 05 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@bbovenzi bbovenzi added the AIP-68 Extended Plugin Interface for React Views label Jul 2, 2025
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 2, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah, also considered picking this up as it would be on my skill level and I saw the gap as well - but you were faster now :-D Thanks! LGTM!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

@pierrejeambrun pierrejeambrun changed the title Add external view plugin categories to admin, browse, docs, user [AIP-68] Add external view plugin categories to admin, browse, docs, user Jul 3, 2025
@pierrejeambrun pierrejeambrun mentioned this pull request Jul 3, 2025
1 task
@bbovenzi bbovenzi merged commit de2ab7b into apache:main Jul 3, 2025
55 checks passed
@bbovenzi bbovenzi deleted the plugin-menu-items branch July 3, 2025 13:45
@pierrejeambrun pierrejeambrun changed the title [AIP-68] Add external view plugin categories to admin, browse, docs, user AIP-68 Add external view plugin categories to admin, browse, docs, user Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-68 Extended Plugin Interface for React Views area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants