Skip to content

AIP-68 Improve plugins menu items #52719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierrejeambrun merged 1 commit into from
Jul 2, 2025
Merged

AIP-68 Improve plugins menu items #52719

pierrejeambrun merged 1 commit into from
Jul 2, 2025

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Jul 2, 2025

Few improvements for the plugin menu items:

  • Similarly to other menus in the application, close the menu once we click on an item
  • Adjust the style to me more consistent with normal menu items (hovering effect, spacing, no outline (even if this hurt accessibility this should really behave like a menu item, no outline))
Screen.Recording.2025-07-02.at.17.16.47.mov

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 2, 2025
@pierrejeambrun pierrejeambrun merged commit eceecff into apache:main Jul 2, 2025
54 checks passed
@pierrejeambrun pierrejeambrun deleted the close-plugin-menues-on-select branch July 2, 2025 16:09
@pierrejeambrun pierrejeambrun changed the title Improve plugins menu items AIP-68 Improve plugins menu items Jul 3, 2025
@pierrejeambrun pierrejeambrun mentioned this pull request Jul 3, 2025
Open
1 task
@jscheffl jscheffl added the AIP-68 Extended Plugin Interface for React Views label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi bbovenzi approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

Assignees

No one assigned

Labels

AIP-68 Extended Plugin Interface for React Views area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierrejeambrun @bbovenzi @jscheffl