Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult #52673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…True for ConnectionResult
…True for ConnectionResult
2 tasks
Contributor
|
@gopidesupavan could you create an issue for the description one? It will likely require a cadwyn migration, so feel free to work on it, or assign to me. |
amoghrajesh
approved these changes
Jul 2, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Good catch, likely a miss +1
eladkal
added
the
backport-to-v3-1-test
eladkal
approved these changes
Jul 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
…se by_alias=True for ConnectionResult (#52673) * Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult * Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult (cherry picked from commit bb93415) Co-authored-by: GPK <gopidesupavan@gmail.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 2, 2025
…se by_alias=True for ConnectionResult (apache#52673) * Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult * Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult (cherry picked from commit bb93415) Co-authored-by: GPK <gopidesupavan@gmail.com>
gopidesupavan
added a commit
that referenced
this pull request
Jul 2, 2025
…se by_alias=True for ConnectionResult (#52673) (#52691) * Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult * Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult (cherry picked from commit bb93415) Co-authored-by: GPK <gopidesupavan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #52319
closes: #52585
We should use by_alias=True to convert schema_ for connection result. as the model has
schema_Note: After seeing the model here https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/api_fastapi/execution_api/datamodels/connection.py#L25, we are missing connection
descriptionfield, will try to get in different PR that change.After change:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.