[AIP-68] Support pluginv2 views #52582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
jscheffl,
ryanahamilton,
shubhamraj-git and
vincbeck
as code owners
boring-cyborg
bot
added
area:providers
area:translations
area:UI
vincbeck
approved these changes
Jun 30, 2025
bbovenzi
approved these changes
Jun 30, 2025
Contributor
|
Fab static check is failing |
jscheffl
approved these changes
Jun 30, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Cool! Legacy FAB is calling :-D
Tweaked a bit in the code and was able with this to make the Edge Plugin working in FAB. Not that I want to have this created again but a proof it is working!
Member
Author
Glad to hear! |
pierrejeambrun
force-pushed
the
support-pluginv2-views
branch
from
c2799f6 to
1b3965c
Compare
pierrejeambrun
force-pushed
the
support-pluginv2-views
branch
from
1b3965c to
763e4dd
Compare
pierrejeambrun
force-pushed
the
support-pluginv2-views
branch
from
763e4dd to
776951c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to see Plugins
flask_app_builder_viewsin Airflow 3.Basically if we detect any
flaks_app_builder_viewsin the plugins, and that those views have a menu entry, (They are not direct access only) we will add a "Legacy FAB views" entry to plugins. This will map topluginsv2and there we will see our views in the menu, with the ability to click on them.Unfortunately I don't think we can guess the view url with the current API information, so we cannot directly map to legacy views from the Airflow 3 plugin menu item.