Skip to content

[AIP-68] Allow Providers Iframe script execution #52569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Jun 30, 2025
Merged

[AIP-68] Allow Providers Iframe script execution #52569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions airflow-core/src/airflow/ui/src/pages/Iframe.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { ProgressBar } from "src/components/ui";

import { ErrorPage } from "./Error";

export const Iframe = () => {
export const Iframe = ({ sandbox = "allow-same-origin allow-forms" }: { readonly sandbox: string }) => {
const { page } = useParams();
const { data: pluginData, isLoading } = usePluginServiceGetPlugins();

Expand All @@ -44,10 +44,6 @@ export const Iframe = () => {
return <ErrorPage />;
}

// The following iframe sandbox setting is intentionally less restrictive.
// ONLY trusted contents can be framed within Iframe.
const sandbox = "allow-same-origin allow-forms";

return (
<Box flexGrow={1} m={-3}>
<iframe
Expand Down
14 changes: 7 additions & 7 deletions airflow-core/src/airflow/ui/src/pages/Security.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ import { ProgressBar } from "src/components/ui";

import { ErrorPage } from "./Error";

// The following iframe sandbox setting is intentionally less restrictive.
// This is considered safe because the framed content originates from the Auth manager,
// which is part of the deployment of Airflow and trusted as per our security policy.
// https://airflow.apache.org/docs/apache-airflow/stable/security/security_model.html
const SANDBOX = "allow-scripts allow-same-origin allow-forms";

export const Security = () => {
const { page } = useParams();

Expand All @@ -43,15 +49,9 @@ export const Security = () => {
return <ErrorPage />;
}

// The following iframe sandbox setting is intentionally less restrictive.
// This is considered safe because the framed content originates from the Auth manager,
// which is part of the deployment of Airflow and trusted as per our security policy.
// https://airflow.apache.org/docs/apache-airflow/stable/security/security_model.html
const sandbox = "allow-scripts allow-same-origin allow-forms";

return (
<Box flexGrow={1} m={-3}>
<iframe sandbox={sandbox} src={link.href} style={{ height: "100%", width: "100%" }} title={link.text} />
<iframe sandbox={SANDBOX} src={link.href} style={{ height: "100%", width: "100%" }} title={link.text} />
</Box>
);
};
7 changes: 6 additions & 1 deletion airflow-core/src/airflow/ui/src/router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,12 @@ export const routerConfig = [
path: "connections",
},
{
element: <Iframe />,
// The following iframe sandbox setting is intentionally less restrictive.
// This is considered safe because the framed content originates from the Plugins,
// which is part of the deployment of Airflow and trusted as per our security policy.
// https://airflow.apache.org/docs/apache-airflow/stable/security/security_model.html
// They are not user provided plugins.
element: <Iframe sandbox="allow-scripts allow-same-origin allow-forms" />,
path: "plugin/:page",
},
{
Expand Down