Skip to content

Generally do not force version_compat.py to have pytests #52496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 1 commit into from
Jun 29, 2025
Merged

Generally do not force version_compat.py to have pytests #52496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 2 additions & 45 deletions airflow-core/tests/unit/always/test_project_structure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ def test_providers_modules_should_have_tests(self):
# We should make sure that one goes to 0
# TODO(potiuk) - check if that test actually tests something
OVERLOOKED_TESTS = [
"providers/airbyte/tests/unit/airbyte/test_version_compat.py",
"providers/alibaba/tests/unit/alibaba/test_version_compat.py",
"providers/amazon/tests/unit/amazon/aws/auth_manager/datamodels/test_login.py",
"providers/amazon/tests/unit/amazon/aws/auth_manager/security_manager/test_aws_security_manager_override.py",
"providers/amazon/tests/unit/amazon/aws/executors/batch/test_batch_executor_config.py",
Expand All @@ -84,26 +82,12 @@ def test_providers_modules_should_have_tests(self):
"providers/amazon/tests/unit/amazon/aws/utils/test_rds.py",
"providers/amazon/tests/unit/amazon/aws/utils/test_sagemaker.py",
"providers/amazon/tests/unit/amazon/aws/waiters/test_base_waiter.py",
"providers/amazon/tests/unit/amazon/test_version_compat.py",
"providers/apache/cassandra/tests/unit/apache/cassandra/test_version_compat.py",
"providers/apache/flink/tests/unit/apache/flink/test_version_compat.py",
"providers/apache/hdfs/tests/unit/apache/hdfs/test_version_compat.py",
"providers/apache/hdfs/tests/unit/apache/hdfs/hooks/test_hdfs.py",
"providers/apache/hdfs/tests/unit/apache/hdfs/log/test_hdfs_task_handler.py",
"providers/apache/hdfs/tests/unit/apache/hdfs/sensors/test_hdfs.py",
"providers/apache/hive/tests/unit/apache/hive/test_version_compat.py",
"providers/apache/hive/tests/unit/apache/hive/plugins/test_hive.py",
"providers/apache/impala/tests/unit/apache/impala/test_version_compat.py",
"providers/apache/livy/tests/unit/apache/livy/test_version_compat.py",
"providers/apache/pig/tests/unit/apache/pig/test_version_compat.py",
"providers/apache/spark/tests/unit/apache/spark/test_version_compat.py",
"providers/apache/tinkerpop/tests/unit/apache/tinkerpop/test_version_compat.py",
"providers/arangodb/tests/unit/arangodb/test_version_compat.py",
"providers/asana/tests/unit/asana/test_version_compat.py",
"providers/atlassian/jira/tests/unit/atlassian/jira/test_version_compat.py",
"providers/celery/tests/unit/celery/executors/test_celery_executor_utils.py",
"providers/celery/tests/unit/celery/executors/test_default_celery.py",
"providers/celery/tests/unit/celery/test_version_compat.py",
"providers/cloudant/tests/unit/cloudant/test_cloudant_fake.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor_types.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor_utils.py",
Expand All @@ -114,35 +98,25 @@ def test_providers_modules_should_have_tests(self):
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/test_kube_config.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/test_python_kubernetes_script.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/test_secret.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/test_version_compat.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/triggers/test_kubernetes_pod.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_delete_from.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_k8s_hashlib_wrapper.py",
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_xcom_sidecar.py",
"providers/common/sql/tests/unit/common/sql/test_version_compat.py",
"providers/common/compat/tests/unit/common/compat/lineage/test_entities.py",
"providers/common/compat/tests/unit/common/compat/standard/test_operators.py",
"providers/common/compat/tests/unit/common/compat/standard/test_triggers.py",
"providers/common/compat/tests/unit/common/compat/standard/test_utils.py",
"providers/common/compat/tests/unit/common/compat/test_version_compat.py",
"providers/common/io/tests/unit/common/io/test_version_compat.py",
"providers/common/messaging/tests/unit/common/messaging/providers/test_base_provider.py",
"providers/common/messaging/tests/unit/common/messaging/providers/test_sqs.py",
"providers/datadog/tests/unit/datadog/test_version_compat.py",
"providers/databricks/tests/unit/databricks/test_version_compat.py",
"providers/dbt/cloud/tests/unit/dbt/cloud/test_version_compat.py",
"providers/docker/tests/unit/docker/test_version_compat.py",
"providers/edge3/tests/unit/edge3/models/test_edge_job.py",
"providers/edge3/tests/unit/edge3/models/test_edge_logs.py",
"providers/edge3/tests/unit/edge3/models/test_edge_worker.py",
"providers/edge3/tests/unit/edge3/test_version_compat.py",
"providers/edge3/tests/unit/edge3/worker_api/routes/test__v2_compat.py",
"providers/edge3/tests/unit/edge3/worker_api/routes/test__v2_routes.py",
"providers/edge3/tests/unit/edge3/worker_api/routes/test_jobs.py",
"providers/edge3/tests/unit/edge3/worker_api/test_app.py",
"providers/edge3/tests/unit/edge3/worker_api/test_auth.py",
"providers/edge3/tests/unit/edge3/worker_api/test_datamodels.py",
"providers/elasticsearch/tests/unit/elasticsearch/test_version_compat.py",
"providers/fab/tests/unit/fab/auth_manager/api_fastapi/datamodels/test_login.py",
"providers/fab/tests/unit/fab/migrations/test_env.py",
"providers/fab/tests/unit/fab/www/api_connexion/test_exceptions.py",
Expand All @@ -165,8 +139,6 @@ def test_providers_modules_should_have_tests(self):
"providers/fab/tests/unit/fab/www/test_session.py",
"providers/fab/tests/unit/fab/www/test_utils.py",
"providers/fab/tests/unit/fab/www/test_views.py",
"providers/ftp/tests/unit/ftp/test_version_compat.py",
"providers/github/tests/unit/github/test_version_compat.py",
"providers/google/tests/unit/google/cloud/fs/test_gcs.py",
"providers/google/tests/unit/google/cloud/links/test_automl.py",
"providers/google/tests/unit/google/cloud/links/test_base.py",
Expand Down Expand Up @@ -215,34 +187,17 @@ def test_providers_modules_should_have_tests(self):
"providers/google/tests/unit/google/common/test_consts.py",
"providers/google/tests/unit/google/common/hooks/test_operation_helpers.py",
"providers/google/tests/unit/google/test_go_module_utils.py",
"providers/google/tests/unit/google/test_version_compat.py",
"providers/http/tests/unit/http/test_version_compat.py",
"providers/http/tests/unit/http/test_exceptions.py",
"providers/imap/tests/unit/imap/test_version_compat.py",
"providers/jenkins/tests/unit/jenkins/test_version_compat.py",
"providers/keycloak/tests/unit/keycloak/auth_manager/datamodels/test_token.py",
"providers/mongo/tests/unit/mongo/test_version_compat.py",
"providers/microsoft/azure/tests/unit/microsoft/azure/operators/test_adls.py",
"providers/microsoft/azure/tests/unit/microsoft/azure/test_version_compat.py",
"providers/openlineage/tests/unit/openlineage/test_version_compat.py",
"providers/opensearch/tests/unit/opensearch/test_version_compat.py",
"providers/oracle/tests/unit/oracle/test_version_compat.py",
"providers/presto/tests/unit/presto/test_version_compat.py",
"providers/redis/tests/unit/redis/test_version_compat.py",
"providers/sftp/tests/unit/sftp/test_version_compat.py",
"providers/snowflake/tests/unit/snowflake/test_version_compat.py",
"providers/snowflake/tests/unit/snowflake/triggers/test_snowflake_trigger.py",
"providers/standard/tests/unit/standard/operators/test_branch.py",
"providers/standard/tests/unit/standard/operators/test_empty.py",
"providers/standard/tests/unit/standard/operators/test_latest_only.py",
"providers/standard/tests/unit/standard/operators/test_trigger_dagrun.py",
"providers/standard/tests/unit/standard/sensors/test_external_task.py",
"providers/standard/tests/unit/standard/sensors/test_filesystem.py",
"providers/standard/tests/unit/standard/test_version_compat.py",
"providers/standard/tests/unit/standard/utils/test_sensor_helper.py",
"providers/tableau/tests/unit/tableau/test_version_compat.py",
"providers/trino/tests/unit/trino/test_version_compat.py",
"providers/weaviate/tests/unit/weaviate/test_version_compat.py",
]
modules_files: list[pathlib.Path] = list(
AIRFLOW_PROVIDERS_ROOT_PATH.glob("**/src/airflow/providers/**/*.py")
Expand Down Expand Up @@ -274,6 +229,8 @@ def test_providers_modules_should_have_tests(self):
current_test_files = set(f for f in current_test_files if not f.name == "__init__.py")
# Exclude node_modules
current_test_files = set(f for f in current_test_files if "node_modules" not in f.parts)
# Exclude version_compat.py
modules_files = filter(lambda f: f.name != "version_compat.py", modules_files)

modules_files_set = set(modules_files)
expected_test_files = set(
Expand Down