Skip to content

Remove pytestmark from Pagerduty test files #52146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Jun 24, 2025
Merged

Remove pytestmark from Pagerduty test files #52146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9adb391
Remove pytestmark from Pagerduty test files
choo121600 Jun 24, 2025
27606f7
Add PagerDuty provider to pre-commit
choo121600 Jun 24, 2025
5762742
fix: airflow.sdk error
choo121600 Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,7 @@ repos:
^providers/openai/.*\.py$|
^providers/openfaas/.*\.py$|
^providers/oracle/.*\.py$|
^providers/pagerduty/.*\.py$|
^providers/pgvector/.*\.py$|
^providers/pinecone/.*\.py$|
^providers/postgres/.*\.py$|
Expand Down
3 changes: 0 additions & 3 deletions providers/pagerduty/tests/unit/pagerduty/hooks/test_pagerduty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
from airflow.models import Connection
from airflow.providers.pagerduty.hooks.pagerduty import PagerdutyHook

pytestmark = pytest.mark.db_test


DEFAULT_CONN_ID = "pagerduty_default"


Expand Down
2 changes: 0 additions & 2 deletions providers/pagerduty/tests/unit/pagerduty/hooks/test_pagerduty_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
from airflow.models import Connection
from airflow.providers.pagerduty.hooks.pagerduty_events import PagerdutyEventsHook

pytestmark = pytest.mark.db_test

DEFAULT_CONN_ID = "pagerduty_events_default"


Expand Down
22 changes: 7 additions & 15 deletions providers/pagerduty/tests/unit/pagerduty/notifications/test_pagerduty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,26 +19,20 @@

from unittest import mock

import pytest

from airflow import DAG
from airflow.providers.pagerduty.hooks.pagerduty_events import PagerdutyEventsHook
from airflow.providers.pagerduty.notifications.pagerduty import (
PagerdutyNotifier,
send_pagerduty_notification,
)
from airflow.providers.standard.operators.empty import EmptyOperator

pytestmark = pytest.mark.db_test


PAGERDUTY_API_DEFAULT_CONN_ID = PagerdutyEventsHook.default_conn_name


class TestPagerdutyNotifier:
@mock.patch("airflow.providers.pagerduty.notifications.pagerduty.PagerdutyEventsHook")
def test_notifier(self, mock_pagerduty_event_hook, dag_maker):
with dag_maker("test_notifier") as dag:
EmptyOperator(task_id="task1")
def test_notifier(self, mock_pagerduty_event_hook):
dag = DAG("test_notifier")
notifier = send_pagerduty_notification(summary="DISK at 99%", severity="critical", action="trigger")
notifier({"dag": dag})
mock_pagerduty_event_hook.return_value.send_event.assert_called_once_with(
Expand All @@ -56,9 +50,8 @@ def test_notifier(self, mock_pagerduty_event_hook, dag_maker):
)

@mock.patch("airflow.providers.pagerduty.notifications.pagerduty.PagerdutyEventsHook")
def test_notifier_with_notifier_class(self, mock_pagerduty_event_hook, dag_maker):
with dag_maker("test_notifier") as dag:
EmptyOperator(task_id="task1")
def test_notifier_with_notifier_class(self, mock_pagerduty_event_hook):
dag = DAG("test_notifier")
notifier = PagerdutyNotifier(summary="DISK at 99%", severity="critical", action="trigger")
notifier({"dag": dag})
mock_pagerduty_event_hook.return_value.send_event.assert_called_once_with(
Expand All @@ -76,9 +69,8 @@ def test_notifier_with_notifier_class(self, mock_pagerduty_event_hook, dag_maker
)

@mock.patch("airflow.providers.pagerduty.notifications.pagerduty.PagerdutyEventsHook")
def test_notifier_templated(self, mock_pagerduty_event_hook, dag_maker):
with dag_maker("test_notifier") as dag:
EmptyOperator(task_id="task1")
def test_notifier_templated(self, mock_pagerduty_event_hook):
dag = DAG("test_notifier")

notifier = PagerdutyNotifier(
summary="DISK at 99% {{dag.dag_id}}",
Expand Down