Skip to content

Remove pytest db markers from common sql provider #52105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jun 23, 2025
Merged

Remove pytest db markers from common sql provider #52105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions providers/common/sql/tests/unit/common/sql/operators/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ def test_generate_sql_query_with_partitions(self, monkeypatch):
== self.correct_generate_sql_query_with_partition.lstrip()
)

@pytest.mark.db_test
def test_generate_sql_query_with_templated_partitions(self, monkeypatch):
checks = self.short_valid_column_mapping["X"]
operator = self._construct_operator(monkeypatch, self.short_valid_column_mapping, ())
Expand Down Expand Up @@ -407,7 +406,6 @@ def test_generate_sql_query_with_check_partition(self, monkeypatch):
)
del self.short_valid_column_mapping["X"]["distinct_check"]["partition_clause"]

@pytest.mark.db_test
@mock.patch.object(SQLColumnCheckOperator, "get_db_hook")
def test_generated_sql_respects_templated_partitions(self, mock_get_db_hook):
records = [
Expand All @@ -433,7 +431,6 @@ def test_generated_sql_respects_templated_partitions(self, mock_get_db_hook):
self._full_check_sql(self.correct_generate_sql_query_with_partition),
)

@pytest.mark.db_test
@mock.patch.object(SQLColumnCheckOperator, "get_db_hook")
def test_generated_sql_respects_templated_table(self, mock_get_db_hook):
records = [
Expand Down Expand Up @@ -620,7 +617,6 @@ def test_generate_sql_query_with_partitions(self, monkeypatch):
operator._generate_sql_query().lstrip() == self.correct_generate_sql_query_with_partition.lstrip()
)

@pytest.mark.db_test
def test_generate_sql_query_with_templated_partitions(self, monkeypatch):
operator = self._construct_operator(monkeypatch, self.checks, ())
operator.partition_clause = "{{ params.col }} > 10"
Expand All @@ -629,7 +625,6 @@ def test_generate_sql_query_with_templated_partitions(self, monkeypatch):
operator._generate_sql_query().lstrip() == self.correct_generate_sql_query_with_partition.lstrip()
)

@pytest.mark.db_test
def test_generate_sql_query_with_templated_table(self, monkeypatch):
operator = self._construct_operator(monkeypatch, self.checks, ())
operator.table = "{{ params.table }}"
Expand Down Expand Up @@ -811,7 +806,6 @@ def _construct_operator(self, sql, pass_value, tolerance=None):
tolerance=tolerance,
)

@pytest.mark.db_test
def test_pass_value_template_string(self):
pass_value_str = "2018-03-22"
operator = self._construct_operator("select date from tab1;", "{{ ds }}")
Expand All @@ -821,7 +815,6 @@ def test_pass_value_template_string(self):
assert operator.task_id == self.task_id
assert operator.pass_value == pass_value_str

@pytest.mark.db_test
def test_pass_value_template_string_float(self):
pass_value_float = 4.0
operator = self._construct_operator("select date from tab1;", pass_value_float)
Expand Down Expand Up @@ -1080,7 +1073,6 @@ def test_fail_if_query_returns_no_rows(self, mock_get_db_hook):
operator.execute(context=MagicMock())


@pytest.mark.db_test
class TestSqlBranch:
"""
Test for SQL Branch Operator
Expand Down Expand Up @@ -1120,7 +1112,6 @@ def branch_op(self):
dag=self.dag,
)

@pytest.mark.db_test
def test_unsupported_conn_type(self):
"""Check if BranchSQLOperator throws an exception for unsupported connection type"""
op = BranchSQLOperator(
Expand Down