Skip to content

Add Pre-Commit Hook To Prevent Usage of session.query #52083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 4 commits into from
Jun 23, 2025
Merged

Add Pre-Commit Hook To Prevent Usage of session.query #52083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4594e9c
add pre-commit hook to prevent usage of session.query
Prab-27 Jun 23, 2025
8c66c73
Add proper name in pre-commit hook id and name
Prab-27 Jun 23, 2025
7007c85
rename pre-commit-python file
Prab-27 Jun 23, 2025
4d225b4
chnage file name from pre-commit hook
Prab-27 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,16 @@ repos:
pass_filenames: false
require_serial: true
additional_dependencies: ['rich>=12.4.4']
- id: prevent-deprecated-sqlalchemy-usage
name: Prevent deprecated sqlalchemy usage
entry: ./scripts/ci/pre_commit/prevent_deprecated_sqlalchemy_usage.py
language: python
additional_dependencies: ['rich>=12.4.4']
files: >
(?x)
^airflow-ctl.*\.py$|
^task_sdk.*\.py$
pass_filenames: true
- id: update-supported-versions
name: Updates supported versions in documentation
entry: ./scripts/ci/pre_commit/supported_versions.py
Expand Down
2 changes: 2 additions & 0 deletions contributing-docs/08_static_code_checks.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,8 @@ require Breeze Docker image to be built locally.
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| pretty-format-json | Format JSON files | |
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| prevent-deprecated-sqlalchemy-usage | Prevent deprecated sqlalchemy usage | |
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| pylint | pylint | |
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| python-no-log-warn | Check if there are no deprecate log warn | |
Expand Down
Loading