Skip to content

[v3-0-test] Remove duplicate 'mock_supervisor_comms' pytest fixtures from core (#49457) #52080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 1 commit into from
Jun 23, 2025
Merged

[v3-0-test] Remove duplicate 'mock_supervisor_comms' pytest fixtures from core (#49457) #52080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions airflow-core/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
from contextlib import contextmanager
from pathlib import Path
from typing import TYPE_CHECKING
from unittest import mock

import pytest

Expand Down Expand Up @@ -126,14 +125,6 @@ def test_zip_path(tmp_path: Path):
return os.fspath(zipped)


@pytest.fixture
def mock_supervisor_comms():
with mock.patch(
"airflow.sdk.execution_time.task_runner.SUPERVISOR_COMMS", create=True
) as supervisor_comms:
yield supervisor_comms


if TYPE_CHECKING:
# Static checkers do not know about pytest fixtures' types and return,
# In case if them distributed through third party packages.
Expand Down
8 changes: 0 additions & 8 deletions airflow-core/tests/unit/hooks/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,6 @@
from tests_common.test_utils.config import conf_vars


@pytest.fixture
def mock_supervisor_comms():
with mock.patch(
"airflow.sdk.execution_time.task_runner.SUPERVISOR_COMMS", create=True
) as supervisor_comms:
yield supervisor_comms


class TestBaseHook:
def test_hook_has_default_logger_name(self):
hook = BaseHook()
Expand Down