Revert "Revert "Remove FAB dependency from Edge3 Provider (#51995)"" #52000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
full tests needed
boring-cyborg
bot
added
area:providers
provider:edge
jscheffl
force-pushed
the
revert-51998-revert-edge-fab
branch
from
32ec3e1 to
c3dff49
Compare
jscheffl
force-pushed
the
revert-51998-revert-edge-fab
branch
from
c3dff49 to
aaf9fa6
Compare
jscheffl
requested review from
Copilot and
potiuk
and removed request for
potiuk
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-applies a previous change that removed the FAB dependency from the Edge3 Provider while ensuring full test coverage. Key changes include modifying test assertions for the plugin’s configuration under different Airflow versions, refactoring the API endpoint setup in the plugin to use FastAPI for Airflow 3.0+, and updating the dependency list in pyproject.toml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| providers/edge3/tests/unit/edge3/plugins/test_edge_executor_plugin.py | Adjusted test assertions to align with the new plugin behavior between Airflow 3.0+ and earlier versions |
| providers/edge3/src/airflow/providers/edge3/plugins/edge_executor_plugin.py | Updated API endpoint configuration and refactored imports and endpoint definitions for compatibility with Airflow 3.0+ |
| providers/edge3/pyproject.toml | Removed the FAB provider dependency for both runtime and development |
Comments suppressed due to low confidence (2)
providers/edge3/tests/unit/edge3/plugins/test_edge_executor_plugin.py:58
- [nitpick] Consider adding an inline comment here to clarify why the expectations for 'appbuilder_views' and 'flask_blueprints' differ between AIRFLOW_V_3_0_PLUS and earlier versions to aid future maintenance.
assert len(rep.appbuilder_views) == 0
providers/edge3/src/airflow/providers/edge3/plugins/edge_executor_plugin.py:222
- [nitpick] Consider adding a brief inline comment explaining why only 'fastapi_apps' is assigned in the AIRFLOW_V_3_0_PLUS branch and why the legacy 'appbuilder_views' and 'flask_blueprints' are omitted, for clarity on the version-specific design decisions.
if AIRFLOW_V_3_0_PLUS:
Contributor
Author
Oh, no, seems need another iteration... :-( |
Contributor
Author
|
Now green... finally... |
Member
👀 |
This was referenced Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to re-apply #51995 with full tests.
Reverts #51998