Fix default setting for hash algorithm for FAB password hash #51858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dpgaspar/Flask-AppBuilder#2332 introduced new configuration parameter, where it defaulted hash algorithm for passwords to "scrypt". However with our (old) version of Werkzeug, scrypt is not supported and default should be set to "pbkdf2:sha256" Fixes: 51854
vincbeck
approved these changes
Jun 17, 2025
Member
Author
|
Tested with Airflow 3.0.2 with 2.2.1 provider -> works: 
|
This was referenced Jun 17, 2025
Member
Author
|
Future-proof fix in FAB dpgaspar/Flask-AppBuilder#2365 |
9 tasks
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
…51858) The dpgaspar/Flask-AppBuilder#2332 introduced new configuration parameter, where it defaulted hash algorithm for passwords to "scrypt". However with our (old) version of Werkzeug, scrypt is not supported and default should be set to "pbkdf2:sha256" Fixes: 51854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dpgaspar/Flask-AppBuilder#2332 introduced new configuration parameter, where it defaulted hash algorithm for passwords to "scrypt". However with our (old) version of Werkzeug, scrypt is not supported and default should be set to "pbkdf2:sha256"
Fixes: #51854
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.