Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Jun 11, 2025

Why

uv run --python 3.9 --with libcst==1.8.1 python -c "from libcst.codemod import CodemodContext" fails with ModuleNotFoundError: No module named 'typing_extensions' while uv run --python 3.10 --with libcst==1.8.1 python -c "from libcst.codemod import CodemodContext" works fine. This breaks check-deferrable-default hook

What

Exclude libcst 1.8.1 for Python 3.9


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@eladkal eladkal added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Jun 11, 2025
@Lee-W Lee-W merged commit 2bd4c17 into apache:main Jun 11, 2025
51 checks passed
@Lee-W Lee-W deleted the exclude-libcst-1.8.1 branch June 11, 2025 08:05
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
* build(pre-commit): ignore 1.8.1 as it misses typing-extensions which is needed in Python 3.9

* build(pyproject.toml): include libcst==1.8.1 for python 3.9 as it misses typing-extentions
(cherry picked from commit 2bd4c17)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

pierrejeambrun pushed a commit that referenced this pull request Jun 11, 2025
* build(pre-commit): ignore 1.8.1 as it misses typing-extensions which is needed in Python 3.9

* build(pyproject.toml): include libcst==1.8.1 for python 3.9 as it misses typing-extentions
(cherry picked from commit 2bd4c17)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants