Use Connection Hook Names for Dropdown instead of connection IDs #51599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
jscheffl
added
area:UI
jscheffl
force-pushed
the
bugfix/use-hook-name-in-connection-form
branch
from
66ac4a3 to
15af79f
Compare
eladkal
approved these changes
Jun 11, 2025
Member
|
I was about to suggest we could still show the id in case the names duplicate. But I guess we can do that if this becomes a problem in the future instead. |
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 11, 2025
…ion IDs (apache#51599) (cherry picked from commit f41f5f2) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Contributor
Author
Yes, also thougth about this but then also checked how it was in 2.x... and there is was the same like in this PR. So just replicated the "as is" state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of discussion in https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1749504803544369 I realized that we are populating the Hook IDs in the connection form dropdowns and not the hook names (which are better suited for display).
Before:
After:
(Note: Fixed sorting post-screenshot)