Skip to content

[v3-0-test] Fix structure edges (#51484) #51489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Jun 6, 2025
Merged

[v3-0-test] Fix structure edges (#51484) #51489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/api_fastapi/core_api/routes/ui/structure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ def structure_data(
asset_expression, entry_node_ref["id"]
)
data["nodes"] += upstream_asset_nodes
data["edges"] = upstream_asset_edges
data["edges"] += upstream_asset_edges

data["edges"] += start_edges + edges + end_edges
data["edges"] += start_edges + end_edges

bind_output_assets_to_tasks(data["edges"], serialized_dag)

Expand Down
28 changes: 14 additions & 14 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_structure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,20 @@ def test_should_return_200_with_asset(self, test_client, asset1_id, asset2_id, a
}
expected = {
"edges": [
{
"is_setup_teardown": None,
"label": None,
"source_id": "external_task_sensor",
"target_id": "task_2",
"is_source_asset": None,
},
{
"is_setup_teardown": None,
"label": None,
"source_id": "task_1",
"target_id": "external_task_sensor",
"is_source_asset": None,
},
{
"is_setup_teardown": None,
"label": None,
Expand Down Expand Up @@ -352,20 +366,6 @@ def test_should_return_200_with_asset(self, test_client, asset1_id, asset2_id, a
"target_id": "task_1",
"is_source_asset": None,
},
{
"is_setup_teardown": None,
"label": None,
"source_id": "external_task_sensor",
"target_id": "task_2",
"is_source_asset": None,
},
{
"is_setup_teardown": None,
"label": None,
"source_id": "task_1",
"target_id": "external_task_sensor",
"is_source_asset": None,
},
{
"is_setup_teardown": None,
"label": None,
Expand Down