Fix structure edges #51484
Merged
Fix structure edges #51484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
rawwar and
shubhamraj-git
as code owners
pierrejeambrun
commented
Jun 6, 2025
jedcunningham
approved these changes
Jun 6, 2025
bugraoz93
approved these changes
Jun 6, 2025
shahar1
approved these changes
Jun 6, 2025
pierrejeambrun
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
(cherry picked from commit 414407b) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Backport successfully created: v3-0-test
|
pierrejeambrun
added a commit
that referenced
this pull request
Jun 6, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #51481 I realized I had some really weird cases of duplicate and removed edges where really it shouldn't.
After investigation it appears that #47381 broke a few things, cf comments bellow.
I don't know how this went unnoticed and didn't break completely the structure from a user / unit test perspective but I think we should release that as soon as possible.
edit: Actually I looked to why, lucky us, when we were overriding the edges, as we duplicate them bellow it does not break everything, but if there's no
upstream, we end up with duplicated edges... which isn't great eithercc:
@kaxil, just in case there's another rc for 3.0.2, I think this one should be included if we get the chanceno rush because it shouldn't break stuff, just raising a warning in the UI console for duplication I believe.