Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Jun 6, 2025

The only difference is CLI airflow dags test set logical date to current time, if not provided.

While we default to None for dag.test. This was fine until but users using it for development of scheduled dags and using context will run into KeyError: 'logical_date' due to #48412


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

The only difference is CLI `airflow dags test` set logical date to current time, if not provided.

While we default to `None` for dag.test. This was fine until but users using it for development of scheduled dags and using context will run into `KeyError: 'logical_date'` due to apache#48412
@kaxil kaxil requested review from amoghrajesh and ashb as code owners June 6, 2025 11:17
@kaxil kaxil added this to the Airflow 3.0.3 milestone Jun 6, 2025
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to fix the CI, rest is good 👍🏽

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
@kaxil kaxil merged commit 3fb3fb3 into apache:main Jun 6, 2025
71 checks passed
@kaxil kaxil deleted the make-dag-test-consistent branch June 6, 2025 13:24
@kaxil kaxil added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Jun 6, 2025
kaxil added a commit that referenced this pull request Jun 6, 2025
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants