Skip to content

Generate FAB assets to fix CI #51444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vincbeck wants to merge 1 commit into from
Closed

Generate FAB assets to fix CI #51444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,6 @@ repos:
- id: compile-fab-assets
name: Compile FAB provider assets
language: node
'types_or': [javascript, ts, tsx]
Copy link
Contributor Author

@vincbeck vincbeck Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why sometimes the assets are not generated. If you modify package.json which define the dependencies, it wont regenerate the assets, although it should. Removing this filter fixes the issue

Copy link
Contributor Author

@vincbeck vincbeck Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this is not the root cause. But we still should remove it for local development

files: ^providers/fab/.*/www/
entry: ./scripts/ci/pre_commit/compile_fab_assets.py
pass_filenames: false
Expand Down
2 changes: 1 addition & 1 deletion ...w/static/dist/743.57634ddb93717b7c8c1a.js → ...w/static/dist/743.365a1eb58dd47776b82f.js
View file
Open in desktop

Large diffs are not rendered by default.

0 ...t/743.57634ddb93717b7c8c1a.js.LICENSE.txt → ...t/743.365a1eb58dd47776b82f.js.LICENSE.txt
View file
Open in desktop
File renamed without changes.
0 ...flowDefaultTheme.48540e25fb1e474cef20.css → ...flowDefaultTheme.ad8dda5568e05025b227.css
View file
Open in desktop
File renamed without changes.
0 ...rflowDefaultTheme.48540e25fb1e474cef20.js → ...rflowDefaultTheme.ad8dda5568e05025b227.js
View file
Open in desktop
File renamed without changes.
0 ...tatic/dist/flash.02dea0c2ac20820e8d1b.css → ...tatic/dist/flash.b79fc1a41842edaebd1e.css
View file
Open in desktop
File renamed without changes.
0 ...static/dist/flash.02dea0c2ac20820e8d1b.js → ...static/dist/flash.b79fc1a41842edaebd1e.js
View file
Open in desktop
File renamed without changes.
0 ...dist/loadingDots.96221bc8b6345c7d65b3.css → ...dist/loadingDots.e0e7d08bf05145b507f1.css
View file
Open in desktop
File renamed without changes.
0 .../dist/loadingDots.96221bc8b6345c7d65b3.js → .../dist/loadingDots.e0e7d08bf05145b507f1.js
View file
Open in desktop
File renamed without changes.
0 ...static/dist/main.49c4d5787ef1f247f004.css → ...static/dist/main.86c51bce5f9ddc8b144c.css
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .../static/dist/main.49c4d5787ef1f247f004.js → .../static/dist/main.86c51bce5f9ddc8b144c.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 .../main.49c4d5787ef1f247f004.js.LICENSE.txt → .../main.86c51bce5f9ddc8b144c.js.LICENSE.txt
View file
Open in desktop
File renamed without changes.
26 changes: 13 additions & 13 deletions providers/fab/src/airflow/providers/fab/www/static/dist/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
{
"airflowDefaultTheme.css": "airflowDefaultTheme.48540e25fb1e474cef20.css",
"airflowDefaultTheme.js": "airflowDefaultTheme.48540e25fb1e474cef20.js",
"flash.css": "flash.02dea0c2ac20820e8d1b.css",
"flash.js": "flash.02dea0c2ac20820e8d1b.js",
"loadingDots.css": "loadingDots.96221bc8b6345c7d65b3.css",
"loadingDots.js": "loadingDots.96221bc8b6345c7d65b3.js",
"main.css": "main.49c4d5787ef1f247f004.css",
"main.js": "main.49c4d5787ef1f247f004.js",
"materialIcons.css": "materialIcons.4fd835641d53f81af3d3.css",
"materialIcons.js": "materialIcons.4fd835641d53f81af3d3.js",
"moment.js": "moment.6943aa3cca9cb1129a71.js",
"runtime.js": "runtime.3c1a5fcbb3c1b7c62ad7.js",
"743.js": "743.57634ddb93717b7c8c1a.js",
"airflowDefaultTheme.css": "airflowDefaultTheme.ad8dda5568e05025b227.css",
"airflowDefaultTheme.js": "airflowDefaultTheme.ad8dda5568e05025b227.js",
"flash.css": "flash.b79fc1a41842edaebd1e.css",
"flash.js": "flash.b79fc1a41842edaebd1e.js",
"loadingDots.css": "loadingDots.e0e7d08bf05145b507f1.css",
"loadingDots.js": "loadingDots.e0e7d08bf05145b507f1.js",
"main.css": "main.86c51bce5f9ddc8b144c.css",
"main.js": "main.86c51bce5f9ddc8b144c.js",
"materialIcons.css": "materialIcons.64ecd8081995e8cc1b62.css",
"materialIcons.js": "materialIcons.64ecd8081995e8cc1b62.js",
"moment.js": "moment.4dc2e04c449ec8a3b41c.js",
"runtime.js": "runtime.086dc01132a20c74861a.js",
"743.js": "743.365a1eb58dd47776b82f.js",
"jquery-ui.min.js": "jquery-ui.min.js",
"jquery-ui.min.css": "jquery-ui.min.css",
"oss-licenses.json": "oss-licenses.json",
Expand Down
0 ...st/materialIcons.4fd835641d53f81af3d3.css → ...st/materialIcons.64ecd8081995e8cc1b62.css
View file
Open in desktop
File renamed without changes.
0 ...ist/materialIcons.4fd835641d53f81af3d3.js → ...ist/materialIcons.64ecd8081995e8cc1b62.js
View file
Open in desktop
File renamed without changes.
0 ...tatic/dist/moment.6943aa3cca9cb1129a71.js → ...tatic/dist/moment.4dc2e04c449ec8a3b41c.js
View file
Open in desktop
File renamed without changes.
0 ...atic/dist/runtime.3c1a5fcbb3c1b7c62ad7.js → ...atic/dist/runtime.086dc01132a20c74861a.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion providers/fab/www-hash.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
9c85fa59b691a60a47c7f37c1ab429a9229467634b77609113b18fd156738db7
83e6236e453a6c8de1e532a13c032e80f12bf22692a51f7eb49a87d8e8f662d8
Loading