Fix lingering task supervisors when EOF is missed
#51020
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
closes apache#50500 Adds a new safeguard for cases where the task subprocess closes before all pipe sockets send EOF. The supervisor now records the process exit time and forcibly closes any sockets still open after `workers.task_supervisor_socket_cleanup_delay`. This stops the supervisor loop from hanging indefinitely and allows the process to exit cleanly.
kaxil
force-pushed
the
supervisor-socket-delay
branch
from
754b1f7 to
12d8452
Compare
kaxil
added
the
backport-to-v3-1-test
Member
|
I don't love this - it "shouldn't" get in this state, and something might be missed as a result |
Member
Author
True, I was being conservative here but I have a different lead too. Verifying 🕐 |
Member
Author
That being said, while I don't love this either, it might not be a bad safeguard since it checks for the |
Member
Author
|
I thought I did -- but not anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50500
Adds a new safeguard for cases where the task subprocess closes before all pipe sockets send EOF.
The supervisor now records the
process exit time and forcibly closes any sockets still open after
workers.socket_cleanup_delay. This stops the supervisor loop from hanging indefinitely and allows the process to exit cleanly.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.