Move macros to task SDK execution_time module #50940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
added
the
backport-to-v3-1-test
ashb
approved these changes
May 22, 2025
kaxil
approved these changes
May 22, 2025
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Looks good, could you double check any documentation too -- if it needs updating
Contributor
Author
|
Yeah i just scanned through, all occurrences have been covered. |
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
(cherry picked from commit f7b8ccd) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Backport successfully created: v3-0-test
|
amoghrajesh
added a commit
that referenced
this pull request
May 22, 2025
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros arent definition time objects, but runtime objects, so moving them to execution_time makes more sense. Ref comment: #50642 (comment)
Works as expected too:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.