Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented May 20, 2025

The command that was generated before:

docker run --rm -u 501:20 \
  -v ~/airflow/clients/python/v2.yaml:/spec.yaml \
  -v ~/airflow/clients/python/tmp:/output \
  openapitools/openapi-generator-cli:v7.13.0 generate \
  --input-spec /spec.yaml \
  --generator-name python \
  --git-user-id None \
  --git-repo-id airflow-client-python \
  --output /output \
  --package-name airflow_client.client \
  --additional-properties packageVersion="3.0.0"

which caused things like __version__ = ""2.10.0"" ( here ) or

__version__ = ""3.0.0"" in here

While this does not cause error the user-agent and things are weird:

self.user_agent = 'OpenAPI-Generator/"3.0.0"/python'

vs

self.user_agent = 'OpenAPI-Generator/3.0.0/python'

The command generated now:

docker run --rm -u 501:20 \
  -v ~/airflow/clients/python/v2.yaml:/spec.yaml \
  -v ~/airflow/clients/python/tmp:/output \
  openapitools/openapi-generator-cli:v7.13.0 generate \
  --input-spec /spec.yaml \
  --generator-name python \
  --git-user-id None \
  --git-repo-id airflow-client-python \
  --output /output \
  --package-name airflow_client.client \
  --additional-properties packageVersion=3.0.0

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

The command that was generated before:

```
docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"'
```

which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or

`__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17)

While this does not cause error the user-agent and things are weird:

```py
self.user_agent = 'OpenAPI-Generator/"3.0.0"/python'
```

vs

```py
self.user_agent = 'OpenAPI-Generator/3.0.0/python'
```
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@kaxil kaxil merged commit e1f4290 into apache:main May 20, 2025
94 of 95 checks passed
@kaxil kaxil deleted the fix-version-client branch May 20, 2025 19:36
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request May 21, 2025
The command that was generated before:

```
docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"'
```

which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or

`__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17)

While this does not cause error the user-agent and things are weird:

```py
self.user_agent = 'OpenAPI-Generator/"3.0.0"/python'
```

vs

```py
self.user_agent = 'OpenAPI-Generator/3.0.0/python'
```
kaxil added a commit that referenced this pull request May 23, 2025
The command that was generated before:

```
docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"'
```

which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or

`__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17)

While this does not cause error the user-agent and things are weird:

```py
self.user_agent = 'OpenAPI-Generator/"3.0.0"/python'
```

vs

```py
self.user_agent = 'OpenAPI-Generator/3.0.0/python'
```

(cherry picked from commit e1f4290)
dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
The command that was generated before:

```
docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"'
```

which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or

`__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17)

While this does not cause error the user-agent and things are weird:

```py
self.user_agent = 'OpenAPI-Generator/"3.0.0"/python'
```

vs

```py
self.user_agent = 'OpenAPI-Generator/3.0.0/python'
```
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
The command that was generated before:

```
docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"'
```

which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or

`__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17)

While this does not cause error the user-agent and things are weird:

```py
self.user_agent = 'OpenAPI-Generator/"3.0.0"/python'
```

vs

```py
self.user_agent = 'OpenAPI-Generator/3.0.0/python'
```
@kaxil kaxil added this to the Airflow 3.0.3 milestone Jun 10, 2025
kaxil added a commit that referenced this pull request Jun 10, 2025
The command that was generated before:

```
docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"'
```

which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or

`__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17)

While this does not cause error the user-agent and things are weird:

```py
self.user_agent = 'OpenAPI-Generator/"3.0.0"/python'
```

vs

```py
self.user_agent = 'OpenAPI-Generator/3.0.0/python'
```

(cherry picked from commit e1f4290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants