-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix the version for generated client #50859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command that was generated before: ``` docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"' ``` which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or `__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17) While this does not cause error the user-agent and things are weird: ```py self.user_agent = 'OpenAPI-Generator/"3.0.0"/python' ``` vs ```py self.user_agent = 'OpenAPI-Generator/3.0.0/python' ```
amoghrajesh
approved these changes
May 20, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
gopidesupavan
approved these changes
May 20, 2025
jedcunningham
approved these changes
May 20, 2025
bugraoz93
approved these changes
May 20, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
May 21, 2025
The command that was generated before: ``` docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"' ``` which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or `__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17) While this does not cause error the user-agent and things are weird: ```py self.user_agent = 'OpenAPI-Generator/"3.0.0"/python' ``` vs ```py self.user_agent = 'OpenAPI-Generator/3.0.0/python' ```
kaxil
added a commit
that referenced
this pull request
May 23, 2025
The command that was generated before: ``` docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"' ``` which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or `__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17) While this does not cause error the user-agent and things are weird: ```py self.user_agent = 'OpenAPI-Generator/"3.0.0"/python' ``` vs ```py self.user_agent = 'OpenAPI-Generator/3.0.0/python' ``` (cherry picked from commit e1f4290)
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
The command that was generated before: ``` docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"' ``` which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or `__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17) While this does not cause error the user-agent and things are weird: ```py self.user_agent = 'OpenAPI-Generator/"3.0.0"/python' ``` vs ```py self.user_agent = 'OpenAPI-Generator/3.0.0/python' ```
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
The command that was generated before: ``` docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"' ``` which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or `__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17) While this does not cause error the user-agent and things are weird: ```py self.user_agent = 'OpenAPI-Generator/"3.0.0"/python' ``` vs ```py self.user_agent = 'OpenAPI-Generator/3.0.0/python' ```
kaxil
added a commit
that referenced
this pull request
Jun 10, 2025
The command that was generated before: ``` docker run --rm -u 501:20 -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/v2.yaml:/spec.yaml -v /Users/kaxilnaik/Documents/GitHub/astronomer/airflow/clients/python/tmp:/output openapitools/openapi-generator-cli:v7.13.0 generate --input-spec /spec.yaml --generator-name python --git-user-id None --output /output --package-name airflow_client.client --git-repo-id airflow-client-python --additional-properties 'packageVersion="3.0.0"' ``` which caused things like `__version__ = ""2.10.0""` ( [here](https://github.com/apache/airflow-client-python/blob/4bd5b2544e30b05bd8cd03502dc99bd6784a20d6/airflow_client/client/__init__.py) ) or `__version__ = ""3.0.0""` in [here](https://github.com/apache/airflow-client-python/blob/38367b1158b777c87f51fe4d6283273031a4fb60/airflow_client/client/__init__.py#L17) While this does not cause error the user-agent and things are weird: ```py self.user_agent = 'OpenAPI-Generator/"3.0.0"/python' ``` vs ```py self.user_agent = 'OpenAPI-Generator/3.0.0/python' ``` (cherry picked from commit e1f4290)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command that was generated before:
which caused things like
__version__ = ""2.10.0""( here ) or__version__ = ""3.0.0""in hereWhile this does not cause error the user-agent and things are weird:
vs
The command generated now:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.