Skip to content

fix: Duplicate region in Snowflake URI no longer breaks OpenLineage #50831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mobuchowski merged 1 commit into from
May 21, 2025
Merged

fix: Duplicate region in Snowflake URI no longer breaks OpenLineage #50831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions providers/snowflake/src/airflow/providers/snowflake/utils/openlineage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,15 @@ def fix_account_name(name: str) -> str:
account, region = spl
cloud = "aws"
else:
account, region, cloud = spl
# region can easily get duplicated without crashing snowflake, so we need to handle that as well
# eg. account_locator.europe-west3.gcp.europe-west3.gcp will be ok for snowflake
account, region, cloud, *rest = spl
rest = [x for x in rest if x not in (region, cloud)]
if rest: # Not sure what could be left here, but leaving this just in case
log.warning(
"Unexpected parts found in Snowflake uri hostname and will be ignored by OpenLineage: %s",
rest,
)
return f"{account}.{region}.{cloud}"

# Check for existing accounts with cloud names
Expand All @@ -72,13 +80,16 @@ def fix_snowflake_sqlalchemy_uri(uri: str) -> str:
"""
Fix snowflake sqlalchemy connection URI to OpenLineage structure.

Snowflake sqlalchemy connection URI has following structure:
Snowflake sqlalchemy connection URI has the following structure:
'snowflake://<user_login_name>:<password>@<account_identifier>/<database_name>/<schema_name>?warehouse=<warehouse_name>&role=<role_name>'
We want account identifier normalized. It can have two forms:
- newer, in form of <organization>-<id>. In this case we want to do nothing.
- older, composed of <id>-<region>-<cloud> where region and cloud can be
- newer, in form of <organization_id>-<account_id>. In this case we want to do nothing.
- older, composed of <account_locator>.<region>.<cloud> where region and cloud can be
optional in some cases. If <cloud> is omitted, it's AWS.
If region and cloud are omitted, it's AWS us-west-1

Current doc on Snowflake account identifiers:
https://docs.snowflake.com/en/user-guide/admin-account-identifier
"""
try:
parts = urlparse(uri)
Expand Down
3 changes: 3 additions & 0 deletions providers/snowflake/tests/unit/snowflake/utils/test_openlineage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ def test_snowflake_sqlite_account_urls(source, target):
("xy12345", "xy12345.us-west-1.aws"), # No '-' or '_' in name
("xy12345.us-west-1.aws", "xy12345.us-west-1.aws"), # Already complete locator
("xy12345.us-west-2.gcp", "xy12345.us-west-2.gcp"), # Already complete locator for GCP
("xy12345.us-west-2.gcp.us-west-2.gcp", "xy12345.us-west-2.gcp"), # Duplicated region
("xy12345.us-west-2.gcp.us-west-2.gcp.us-west-2.gcp", "xy12345.us-west-2.gcp"), # Triple region
("xy12345.us-west-2.gcp.some_random_part", "xy12345.us-west-2.gcp"), # Suffix to locator, ignored
("xy12345aws", "xy12345aws.us-west-1.aws"), # AWS without '-' or '_'
("xy12345-aws", "xy12345-aws"), # AWS with '-'
("xy12345_gcp-europe-west1", "xy12345.europe-west1.gcp"), # GCP with '_'
Expand Down