[v3-0-test] Fix memory leak in dag-processor (#50558) #50559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #50097 closes #49887 Previously, each `DagFileProcessorProcess` created its own `InProcessExecutionAPI` client instance, leading to unnecessary thread creation and resource use. This commit ensures that a single `Client` backed by `InProcessExecutionAPI` is created and owned by `DagFileProcessorManager`, and passed into all DAG file processor subprocesses. (cherry picked from commit 3dc597f) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
force-pushed
the
backport-3dc597f-v3-0-test
branch
from
9936c59 to
b80257f
Compare
tirkarthi
approved these changes
May 14, 2025
Contributor
tirkarthi
left a comment
tirkarthi
left a comment
There was a problem hiding this comment.
LGTM. Test failure seems to be unrelated. Thanks.
kaxil
added a commit
that referenced
this pull request
Jun 3, 2025
closes #50097 closes #49887 Previously, each `DagFileProcessorProcess` created its own `InProcessExecutionAPI` client instance, leading to unnecessary thread creation and resource use. This commit ensures that a single `Client` backed by `InProcessExecutionAPI` is created and owned by `DagFileProcessorManager`, and passed into all DAG file processor subprocesses. (cherry picked from commit 3dc597f) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50097
closes #49887
Previously, each
DagFileProcessorProcesscreated its ownInProcessExecutionAPIclient instance, leading to unnecessary thread creation and resource use.
This commit ensures that a single
Clientbacked byInProcessExecutionAPIis createdand owned by
DagFileProcessorManager, and passed into all DAG file processor subprocesses.(cherry picked from commit 3dc597f)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com