Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented May 13, 2025

When we are rerunning the old doc builds, we really want to overwrite existing documentation, there is no point in silently skipping the docs - this is useful for manual pushing because you can make a mistake easily but when you are runnig it in workflow, you run it from a specified tag and the docs are for sure built from this tag so our intention is to override it.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk requested review from ashb and gopidesupavan as code owners May 13, 2025 14:31
@potiuk potiuk requested review from eladkal and kaxil May 13, 2025 14:31
@potiuk
Copy link
Member Author

potiuk commented May 13, 2025

I found it out when I tried to re-publish amazon and snowflake with --include-commits

@potiuk
Copy link
Member Author

potiuk commented May 13, 2025

@potiuk potiuk added this to the Airflow 3.0.2 milestone May 13, 2025
@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label May 13, 2025
@potiuk potiuk changed the title Add --owerwrite when publishing documentation to S3 Add --overwrite when publishing documentation to S3 May 13, 2025
When we are rerunning the old doc builds, we really want to overwrite
existing documentation, there is no point in silently skipping the
docs - this is useful for manual pushing because you can make a
mistake easily but when you are runnig it in workflow, you run it
from a specified tag and the docs are for sure built from this tag
so our intention is to override it.
@potiuk potiuk force-pushed the add-overwrite-to-publishing-to-s3 branch from 3f88d95 to 12ad134 Compare May 13, 2025 15:12
@potiuk potiuk merged commit d88bf3f into apache:main May 13, 2025
78 of 79 checks passed
@potiuk potiuk deleted the add-overwrite-to-publishing-to-s3 branch May 13, 2025 15:24
@github-actions
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker d88bf3f v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk added a commit to potiuk/airflow that referenced this pull request May 14, 2025
…he#50543)

When we are rerunning the old doc builds, we really want to overwrite
existing documentation, there is no point in silently skipping the
docs - this is useful for manual pushing because you can make a
mistake easily but when you are runnig it in workflow, you run it
from a specified tag and the docs are for sure built from this tag
so our intention is to override it.
(cherry picked from commit d88bf3f)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit that referenced this pull request May 14, 2025
…) (#50611)

When we are rerunning the old doc builds, we really want to overwrite
existing documentation, there is no point in silently skipping the
docs - this is useful for manual pushing because you can make a
mistake easily but when you are runnig it in workflow, you run it
from a specified tag and the docs are for sure built from this tag
so our intention is to override it.
(cherry picked from commit d88bf3f)
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…) (#50611)

When we are rerunning the old doc builds, we really want to overwrite
existing documentation, there is no point in silently skipping the
docs - this is useful for manual pushing because you can make a
mistake easily but when you are runnig it in workflow, you run it
from a specified tag and the docs are for sure built from this tag
so our intention is to override it.
(cherry picked from commit d88bf3f)
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
When we are rerunning the old doc builds, we really want to overwrite
existing documentation, there is no point in silently skipping the
docs - this is useful for manual pushing because you can make a
mistake easily but when you are runnig it in workflow, you run it
from a specified tag and the docs are for sure built from this tag
so our intention is to override it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants