Install sphinx-airflow-theme package from GitHub release not pypi
#50459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need to publish sphinx-airflow-theme in PyPI - we can simply install the package directly from the wheel file published during `main` build of the `airflow-site` - this way we will always use the latest "main" version of the theme and we have no need to publish such newer versions of packages to PyPI. This means that any committer can modify site theme and build it in sites and after merging to main, the theme will be used automatically from there.
Member
Author
|
After this one is merged (and we cherry-pick this change to old branches), we can stop publishing |
Member
|
Nice :) |
gopidesupavan
approved these changes
May 11, 2025
jscheffl
approved these changes
May 11, 2025
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 11, 2025
…not `pypi` (apache#50459) We do not need to publish sphinx-airflow-theme in PyPI - we can simply install the package directly from the wheel file published during `main` build of the `airflow-site` - this way we will always use the latest "main" version of the theme and we have no need to publish such newer versions of packages to PyPI. This means that any committer can modify site theme and build it in sites and after merging to main, the theme will be used automatically from there. (cherry picked from commit eb194c9) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 11, 2025
… not `pypi` (apache#50459) We do not need to publish sphinx-airflow-theme in PyPI - we can simply install the package directly from the wheel file published during `main` build of the `airflow-site` - this way we will always use the latest "main" version of the theme and we have no need to publish such newer versions of packages to PyPI. This means that any committer can modify site theme and build it in sites and after merging to main, the theme will be used automatically from there. (cherry picked from commit eb194c9) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 11, 2025
The apache#50459 added installing airflow-sphinx-theme from remote URL, but it broke compatibility tests "unistallation".
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 11, 2025
… not `pypi` (apache#50459) We do not need to publish sphinx-airflow-theme in PyPI - we can simply install the package directly from the wheel file published during `main` build of the `airflow-site` - this way we will always use the latest "main" version of the theme and we have no need to publish such newer versions of packages to PyPI. This means that any committer can modify site theme and build it in sites and after merging to main, the theme will be used automatically from there. (cherry picked from commit eb194c9) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
May 11, 2025
…not `pypi` (#50459) (#50465) We do not need to publish sphinx-airflow-theme in PyPI - we can simply install the package directly from the wheel file published during `main` build of the `airflow-site` - this way we will always use the latest "main" version of the theme and we have no need to publish such newer versions of packages to PyPI. This means that any committer can modify site theme and build it in sites and after merging to main, the theme will be used automatically from there. (cherry picked from commit eb194c9)
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…not `pypi` (#50459) (#50465) We do not need to publish sphinx-airflow-theme in PyPI - we can simply install the package directly from the wheel file published during `main` build of the `airflow-site` - this way we will always use the latest "main" version of the theme and we have no need to publish such newer versions of packages to PyPI. This means that any committer can modify site theme and build it in sites and after merging to main, the theme will be used automatically from there. (cherry picked from commit eb194c9)
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…pache#50459) We do not need to publish sphinx-airflow-theme in PyPI - we can simply install the package directly from the wheel file published during `main` build of the `airflow-site` - this way we will always use the latest "main" version of the theme and we have no need to publish such newer versions of packages to PyPI. This means that any committer can modify site theme and build it in sites and after merging to main, the theme will be used automatically from there.
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
apache#50468) The apache#50459 added installing airflow-sphinx-theme from remote URL, but it broke compatibility tests "unistallation".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to publish sphinx-airflow-theme in PyPI - we can simply install the package directly from the wheel file published during
mainbuild of theairflow-site- this way we will always use the latest "main" version of the theme and we have no need to publish such newer versions of packages to PyPI.This means that any committer can modify site theme and build it in sites and after merging to main, the theme will be used automatically from there.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.