Skip to content

Move AWS auth dependencies to python3-saml extra #50449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
May 22, 2025
Merged

Move AWS auth dependencies to python3-saml extra #50449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airflow-core/docs/extra-packages-ref.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ other packages that can be used by airflow or some of its providers.
+=====================+=====================================================+============================================================================+
| aiobotocore | ``pip install 'apache-airflow[aiobotocore]'`` | Support for asynchronous (deferrable) operators for Amazon integration |
+---------------------+-----------------------------------------------------+----------------------------------------------------------------------------+
| amazon-aws-auth | ``pip install apache-airflow[amazon-aws-auth]`` | Amazon-aws-auth AWS authentication |
+---------------------+-----------------------------------------------------+----------------------------------------------------------------------------+
| cloudpickle | ``pip install apache-airflow[cloudpickle]`` | Cloudpickle hooks and operators |
+---------------------+-----------------------------------------------------+----------------------------------------------------------------------------+
| github-enterprise | ``pip install 'apache-airflow[github-enterprise]'`` | GitHub Enterprise auth backend |
Expand Down
9 changes: 4 additions & 5 deletions providers/amazon/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,6 @@ dependencies = [
"asgiref>=2.3.0",
"PyAthena>=3.10.0",
"jmespath>=0.7.0",
"python3-saml>=1.16.0",
# python3-saml is dependent on xmlsec and seems they do not pin it, pinning here would be needed
# We can remove it after https://github.com/xmlsec/python-xmlsec/issues/344 is fixed
"xmlsec!=1.3.15,>=1.3.14",
"lxml<5.4.0,>=5.3.2",
"sagemaker-studio>=1.0.9",
"marshmallow>=3",
]
Expand All @@ -102,6 +97,10 @@ dependencies = [
]
"python3-saml" = [
"python3-saml>=1.16.0",
# python3-saml is dependent on xmlsec and seems they do not pin it, pinning here would be needed
# We can remove it after https://github.com/xmlsec/python-xmlsec/issues/344 is fixed
"xmlsec!=1.3.15,>=1.3.14",
"lxml<5.4.0,>=5.3.2",
]
"apache.hive" = [
"apache-airflow-providers-apache-hive"
Expand Down
8 changes: 7 additions & 1 deletion providers/amazon/tests/unit/amazon/aws/auth_manager/routes/test_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,19 @@
pytest.skip("AWS auth manager is only compatible with Airflow >= 3.0.0", allow_module_level=True)

from fastapi.testclient import TestClient
from onelogin.saml2.idp_metadata_parser import OneLogin_Saml2_IdPMetadataParser

from airflow.api_fastapi.app import AUTH_MANAGER_FASTAPI_APP_PREFIX, create_app

from tests_common.test_utils.config import conf_vars
from tests_common.test_utils.mock_plugins import mock_plugin_manager

# onelogin is optional dependency from apache-airflow-providers-amazon[python3-saml]
# we want to skip it for the lowest dependency checks as it does not install extra dependencies
# https://github.com/apache/airflow/pull/50449#issuecomment-2897572327
OneLogin_Saml2_IdPMetadataParser = pytest.importorskip(
"onelogin.saml2.idp_metadata_parser"
).OneLogin_Saml2_IdPMetadataParser

SAML_METADATA_URL = "/saml/metadata"
SAML_METADATA_PARSED = {
"idp": {
Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ packages = []
"apache-airflow-providers-zendesk>=4.9.0"
]
"all" = [
"apache-airflow[aiobotocore,apache-atlas,apache-webhdfs,async,cloudpickle,github-enterprise,google-auth,graphviz,kerberos,ldap,otel,pandas,polars,rabbitmq,s3fs,sentry,statsd,uv]",
"apache-airflow[aiobotocore,amazon-aws-auth,apache-atlas,apache-webhdfs,async,cloudpickle,github-enterprise,google-auth,graphviz,kerberos,ldap,otel,pandas,polars,rabbitmq,s3fs,sentry,statsd,uv]",
"apache-airflow-core[all]",
"apache-airflow-providers-airbyte>=5.0.0",
"apache-airflow-providers-alibaba>=3.0.0",
Expand Down Expand Up @@ -493,6 +493,9 @@ packages = []
"apache-webhdfs" = [
"apache-airflow-providers-apache-hdfs",
]
"amazon-aws-auth" = [
"apache-airflow-providers-amazon[python3-saml]",
]
"cloudpickle" = [
"cloudpickle>=2.2.1",
]
Expand Down