Skip to content

fix(snowflake_oauth): Fix infinite recursive call of _get_conn_params while getting oauth token from snowflake #50344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 5 commits into from
May 8, 2025
Merged

fix(snowflake_oauth): Fix infinite recursive call of _get_conn_params while getting oauth token from snowflake #50344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85d94eb
fix(snowflake_oauth): Fix infinite recursive call of _get_conn_params…
Sharashchandra May 8, 2025
bb43126
fix(snowflake_oauth): Reverting account_identifier as a property, usi…
Sharashchandra May 8, 2025
0702079
fix(snowflake_oauth): Adding https:// for the snowflake oauth url
Sharashchandra May 8, 2025
a0aee34
fix(snowflake_oauth): Fix test case for oauth which was expecting reg…
Sharashchandra May 8, 2025
4c160ec
fix(snowflake_oauth): Fix failing text cases for snowflake api hook u…
Sharashchandra May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def _get_field(self, extra_dict, field_name):

@property
def account_identifier(self) -> str:
"""Returns snowflake account identifier."""
"""Get snowflake account identifier."""
conn_config = self._get_conn_params
account_identifier = f"https://{conn_config['account']}"

Expand All @@ -205,7 +205,7 @@ def get_oauth_token(self, conn_config: dict | None = None) -> str:
if conn_config is None:
conn_config = self._get_conn_params

url = f"{self.account_identifier}.snowflakecomputing.com/oauth/token-request"
url = f"https://{conn_config['account']}.snowflakecomputing.com/oauth/token-request"

data = {
"grant_type": "refresh_token",
Expand Down
2 changes: 1 addition & 1 deletion providers/snowflake/tests/unit/snowflake/hooks/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@ def test_get_oauth_token(self, mock_conn_param, requests_post, mock_auth):
hook = SnowflakeHook(snowflake_conn_id="mock_conn_id")
hook.get_oauth_token(conn_config=CONN_PARAMS_OAUTH)
requests_post.assert_called_once_with(
f"https://{CONN_PARAMS_OAUTH['account']}.{CONN_PARAMS_OAUTH['region']}.snowflakecomputing.com/oauth/token-request",
f"https://{CONN_PARAMS_OAUTH['account']}.snowflakecomputing.com/oauth/token-request",
data={
"grant_type": "refresh_token",
"refresh_token": CONN_PARAMS_OAUTH["refresh_token"],
Expand Down
2 changes: 1 addition & 1 deletion providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def test_get_oauth_token(self, mock_conn_param, requests_post, mock_auth):
with pytest.warns(expected_warning=AirflowProviderDeprecationWarning):
hook.get_oauth_token(CONN_PARAMS_OAUTH)
requests_post.assert_called_once_with(
f"https://{CONN_PARAMS_OAUTH['account']}.{CONN_PARAMS_OAUTH['region']}.snowflakecomputing.com/oauth/token-request",
f"https://{CONN_PARAMS_OAUTH['account']}.snowflakecomputing.com/oauth/token-request",
data={
"grant_type": "refresh_token",
"refresh_token": CONN_PARAMS_OAUTH["refresh_token"],
Expand Down