Skip to content

fix(snowflake): infinite loop via moving the _get_conn_params call to drive class #50319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bugraoz93 wants to merge 1 commit into from
Closed

fix(snowflake): infinite loop via moving the _get_conn_params call to drive class #50319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,8 @@ def account_identifier(self) -> str:

return account_identifier

def get_oauth_token(self, conn_config: dict | None = None) -> str:
def get_oauth_token(self, conn_config: dict) -> str:
"""Generate temporary OAuth access token using refresh token in connection details."""
if conn_config is None:
conn_config = self._get_conn_params

url = f"{self.account_identifier}.snowflakecomputing.com/oauth/token-request"

data = {
Expand Down
5 changes: 4 additions & 1 deletion providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,13 @@ def get_headers(self) -> dict[str, Any]:
def get_oauth_token(self, conn_config: dict[str, Any] | None = None) -> str:
"""Generate temporary OAuth access token using refresh token in connection details."""
warnings.warn(
"This method is deprecated. Please use `get_oauth_token` method from `SnowflakeHook` instead. ",
"This method is deprecated. Please use `get_oauth_token` method from `SnowflakeHook` instead.",
AirflowProviderDeprecationWarning,
stacklevel=2,
)
if conn_config is None:
conn_config = self._get_conn_params

return super().get_oauth_token(conn_config=conn_config)

def get_request_url_header_params(self, query_id: str) -> tuple[dict[str, Any], dict[str, Any], str]:
Expand Down
Loading