add readiness and liveliness support for git sync relay sidecars #50218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
Contributor
Author
|
@hussein-awala @dstandish can i get a review on this PR |
Contributor
Author
|
Internal Issue link for reference -> https://github.com/astronomer/issues/issues/6929 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
romsharon98
reviewed
Jun 20, 2025
eladkal
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Contributor
|
@pgvishnuram are you still working on this PR? |
Contributor
Author
|
@eladkal this change works as expected are we good to merge i was waiting for approval |
potiuk
approved these changes
Aug 5, 2025
eladkal
removed
the
stale
Nataneljpwd
pushed a commit
to Asquator/airflow
that referenced
this pull request
Aug 5, 2025
…che#50218) * add liveliness and readiness probes support in git sync template * update templates * add tests * add git sync worker tests * add webserver git sync tests * fix pre-commit * fix webserver tests * update scheduler tests * fix ci precommit failures
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Aug 5, 2025
…che#50218) * add liveliness and readiness probes support in git sync template * update templates * add tests * add git sync worker tests * add webserver git sync tests * fix pre-commit * fix webserver tests * update scheduler tests * fix ci precommit failures
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
…che#50218) * add liveliness and readiness probes support in git sync template * update templates * add tests * add git sync worker tests * add webserver git sync tests * fix pre-commit * fix webserver tests * update scheduler tests * fix ci precommit failures
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
…che#50218) * add liveliness and readiness probes support in git sync template * update templates * add tests * add git sync worker tests * add webserver git sync tests * fix pre-commit * fix webserver tests * update scheduler tests * fix ci precommit failures
2 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds support for liveliness and readiness probe configuration to airflow sidecar container when gitsync is enabled and additional adds a skip condition for git sync initContainers which does not support probes as per kubernetes schema
Motivation
This is quite useful in places where companies has strict requirement of defining probes in all containers