Run parallel tests for ARM platform #50198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
changed the title
potiuk
force-pushed
the
add-arm-tests
branch
5 times, most recently
from
5f4d41f to
0fb76c6
Compare
potiuk
force-pushed
the
add-arm-tests
branch
3 times, most recently
from
f9d99d0 to
9ce9f07
Compare
gopidesupavan
approved these changes
May 5, 2025
Member
gopidesupavan
left a comment
gopidesupavan
left a comment
There was a problem hiding this comment.
Super cool, now we have both :)
jason810496
reviewed
May 6, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Rerun the test as it seems to be flaky.
potiuk
force-pushed
the
add-arm-tests
branch
2 times, most recently
from
726a785 to
221fc39
Compare
Member
Author
|
For now I disabled the "pull request" trigger: The tests will run:
This will not have impact on regular PRs and we will have time to observe stability |
Since we have `ubintu22.04-arm` public runners available, we should be able to run a set of parallel tests for ARM - this would make our ARM images move out of experimental phase. We are not running "all" tests - only those that make sense to run on ARM for "production" quality. MySQL tests have some timeouts and run longer on ARM, that's why we do not run MySQL tests on ARM as well. We can also get rid of the "ARM collection" test that was introduced to test if just **collection** of tests when we remove packages that shoud not be installed on ARM works. But if we are running actual pytest tests on ARM, we do not need to run those tests any more.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 6, 2025
Since we have `ubintu22.04-arm` public runners available, we should be able to run a set of parallel tests for ARM - this would make our ARM images move out of experimental phase. We are not running "all" tests - only those that make sense to run on ARM for "production" quality. MySQL tests have some timeouts and run longer on ARM, that's why we do not run MySQL tests on ARM as well. We can also get rid of the "ARM collection" test that was introduced to test if just **collection** of tests when we remove packages that shoud not be installed on ARM works. But if we are running actual pytest tests on ARM, we do not need to run those tests any more. (cherry picked from commit 3198aad) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
May 6, 2025
Since we have `ubintu22.04-arm` public runners available, we should be able to run a set of parallel tests for ARM - this would make our ARM images move out of experimental phase. We are not running "all" tests - only those that make sense to run on ARM for "production" quality. MySQL tests have some timeouts and run longer on ARM, that's why we do not run MySQL tests on ARM as well. We can also get rid of the "ARM collection" test that was introduced to test if just **collection** of tests when we remove packages that shoud not be installed on ARM works. But if we are running actual pytest tests on ARM, we do not need to run those tests any more. (cherry picked from commit 3198aad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have
ubintu22.04-armpublic runners available, we should be able to run a set of parallel tests for ARM - this would make our ARM images move out of experimental phase.We are not running "all" tests - only those that make sense to run on ARM for "production" quality.
MySQL tests have some timeouts and run longer on ARM, that's why we
do not run MySQL tests on ARM as well.
We can also get rid of the "ARM collection" test that was introduced
to test if just collection of tests when we remove packages that
shoud not be installed on ARM works. But if we are running actual
pytest tests on ARM, we do not need to run those tests any more.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.