Make clear_task_instances kwarg only and dag required #50058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making dag required helps me in apache#50040. It's always passed in all production code so, we can make the change. Should be thought of as private anyway. And making it kwarg only, well why not.
dstandish
requested review from
XD-DENG,
ashb,
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar,
shubhamraj-git and
uranusjr
as code owners
boring-cyborg
bot
added
area:API
uranusjr
reviewed
May 2, 2025
Member
There was a problem hiding this comment.
With dag being required, we should also get rid of the DagBag inside the function. This should speed things up quite a bit.
Member
There was a problem hiding this comment.
+1 for that, looks good to me otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making dag required helps me in #50040. It's always passed in all production code so, we can make the change. Should be thought of as private anyway. And making it kwarg only, well why not.