Skip to content

Bump min Airflow version in providers to 2.10 #49843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eladkal merged 3 commits into from
Apr 28, 2025
Merged

Bump min Airflow version in providers to 2.10 #49843

eladkal merged 3 commits into from
Apr 28, 2025

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Apr 27, 2025 •
edited
Loading

I didn't remove the references to AIRFLOW_V_2_10_PLUS as part of this PR.
we can do that after the release and specifically after we verify if we do 2.11 or not

jscheffl
jscheffl reviewed Apr 27, 2025
View reviewed changes
jscheffl
jscheffl reviewed Apr 27, 2025
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the respective providers/**/pyproject.toml also need to be adjusted to have >=2.10 as depenedency marked? And then pre-commit would re-generate some other files as well...

Otherwise looks good.

@eladkal eladkal force-pushed the bump branch 3 times, most recently from 69e3613 to 939e244 Compare April 27, 2025 10:17
jscheffl
jscheffl approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...

@jscheffl
Copy link
Contributor

jscheffl commented Apr 27, 2025

Looks good...

...except the one small static check... :-D

@potiuk
Copy link
Member

potiuk commented Apr 27, 2025

I didn't remove the references to AIRFLOW_V_2_10_PLUS as part of this PR.
we can do that after the release and specifically after we verify if we do 2.11 or not

You can safely remove it now. It does not matter if we release 2.11 or not. If we decide to release 2.11, we should ADD AIRFLOW_V_2_11_PLUS as a constant - removal of AIRFLOW_V_2_10_PLUS is determined simply by the fact that >=2.10 automatically means that everything is AIRFLOW_V2_10_PLUS, so all the code that is not in the if can be removed and the constant can be removed as well.

amoghrajesh
amoghrajesh reviewed Apr 28, 2025
View reviewed changes
@eladkal
Copy link
Contributor Author

eladkal commented Apr 28, 2025

I didn't remove the references to AIRFLOW_V_2_10_PLUS as part of this PR.
we can do that after the release and specifically after we verify if we do 2.11 or not

You can safely remove it now. It does not matter if we release 2.11 or not. If we decide to release 2.11, we should ADD AIRFLOW_V_2_11_PLUS as a constant - removal of AIRFLOW_V_2_10_PLUS is determined simply by the fact that >=2.10 automatically means that everything is AIRFLOW_V2_10_PLUS, so all the code that is not in the if can be removed and the constant can be removed as well.

Will handle the removal separately in parallel. I want to move forward in merge so I can prepare changelogs.
This part is not automated yet so it takes long time

@potiuk
Copy link
Member

potiuk commented Apr 28, 2025

Will handle the removal separately in parallel. I want to move forward in merge so I can prepare changelogs.
This part is not automated yet so it takes long time

Yep. Happy to help.

@eladkal eladkal merged commit 0f573ee into apache:main Apr 28, 2025
96 checks passed
@eladkal eladkal deleted the bump branch April 28, 2025 09:36
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
@eladkal @mvfc
Bump min Airflow version in providers to 2.10 (apache#49843)
8c51592 
* Bump min Airflow version in providers to 2.10

* exclude msgraph test

* fixes
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
@eladkal @mvfc
Bump min Airflow version in providers to 2.10 (apache#49843)
4f26bb3 
* Bump min Airflow version in providers to 2.10

* exclude msgraph test

* fixes
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
@eladkal @mvfc
Bump min Airflow version in providers to 2.10 (apache#49843)
1d754bf 
* Bump min Airflow version in providers to 2.10

* exclude msgraph test

* fixes
jroachgolf84 pushed a commit to jroachgolf84/airflow that referenced this pull request Apr 30, 2025
@eladkal @jroachgolf84
Bump min Airflow version in providers to 2.10 (apache#49843)
c586d3b 
* Bump min Airflow version in providers to 2.10

* exclude msgraph test

* fixes
This was referenced May 5, 2025
Closed
Closed
Closed
@eladkal eladkal mentioned this pull request May 20, 2025
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoghrajesh amoghrajesh amoghrajesh left review comments

@hussein-awala hussein-awala hussein-awala approved these changes

@jscheffl jscheffl jscheffl approved these changes

@vincbeck vincbeck vincbeck approved these changes

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

@Fokko Fokko Awaiting requested review from Fokko Fokko is a code owner

@mik-laj mik-laj Awaiting requested review from mik-laj

@mobuchowski mobuchowski Awaiting requested review from mobuchowski mobuchowski is a code owner

@josh-fell josh-fell Awaiting requested review from josh-fell josh-fell is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

Assignees

No one assigned

Labels

area:dev-tools area:providers provider:airbyte provider:alibaba provider:amazon AWS/Amazon - related issues provider:apache-beam provider:apache-cassandra provider:apache-drill provider:apache-druid provider:apache-flink provider:apache-hdfs provider:apache-hive provider:apache-iceberg provider:apache-impala provider:apache-kafka provider:apache-kylin provider:apache-livy provider:apache-pig provider:apache-pinot provider:apache-spark provider:apache-tinkerpop provider:apprise provider:arangodb provider:asana provider:atlassian-jira

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eladkal @jscheffl @potiuk @hussein-awala @amoghrajesh @vincbeck