Remove old dynamic attr accessing re dag resource in FAB provider #49669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like it used to be a backcompat thing. But now the permissons module is included in fab provider, so the `if getattr` logic always evaluates true. So the else block does nothing. So we can remove it and remove this `_resource_name` helper. Additionally, I remove some `root_dag_id` logic that is also obsolete, since min provider version for fab is 3.0.0.
dstandish
force-pushed
the
remove-dynamice-attr-access-fab
branch
from
c131655 to
b2d6023
Compare
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
…ache#49669) This looks like it used to be a backcompat thing. But now the permissons module is included in fab provider, so the `if getattr` logic always evaluates true. So the else block does nothing. So we can remove it and remove this `_resource_name` helper. Additionally, I remove some `root_dag_id` logic that is also obsolete, since min provider version for fab is 3.0.0.
8 tasks
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
…ache#49669) This looks like it used to be a backcompat thing. But now the permissons module is included in fab provider, so the `if getattr` logic always evaluates true. So the else block does nothing. So we can remove it and remove this `_resource_name` helper. Additionally, I remove some `root_dag_id` logic that is also obsolete, since min provider version for fab is 3.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like it used to be a backcompat thing. But now the permissons module is included in fab provider, so the
if getattrlogic always evaluates true. So the else block does nothing. So we can remove it and remove this_resource_namehelper. Additionally, I remove someroot_dag_idlogic that is also obsolete, since min provider version for fab is 3.0.0.