Add SimpleAllAdminMiddleware to allow api usage without auth header in request #49599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawwar
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
shubhamraj-git and
vincbeck
as code owners
Contributor
|
I like the idea! |
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
I like the approach, looks good to me.
vincbeck
approved these changes
Apr 23, 2025
bugraoz93
approved these changes
Apr 23, 2025
Contributor
|
Thanks Kalyan! |
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice thanks, a few nits
airflow-core/tests/unit/api_fastapi/auth/managers/simple/test_middleware.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/auth/managers/simple/middleware.py
Outdated
Show resolved
Hide resolved
…/all_admin_allow_api_calls
…/all_admin_allow_api_calls
ashb
reviewed
Apr 24, 2025
airflow-core/src/airflow/api_fastapi/auth/managers/simple/middleware.py
Outdated
Show resolved
Hide resolved
rawwar
commented
Apr 24, 2025
pierrejeambrun
approved these changes
Apr 24, 2025
pierrejeambrun
added
type:bug-fix
pierrejeambrun
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
…uth header in request (#49599) * add SimpleAllAdminMiddleware * add tests * update test * update test name * refactor test * sort test order * hardcode endpoints * use session * db_test mark * iterate over app.routes * use fewer endpoints * update comment * update scope (cherry picked from commit 003bf6d) Co-authored-by: Kalyan R <kalyan.ben10@live.com>
Backport successfully created: v3-0-test
|
pierrejeambrun
changed the title
pierrejeambrun
pushed a commit
that referenced
this pull request
Apr 24, 2025
…uth header in request (#49599) (#49743) * add SimpleAllAdminMiddleware * add tests * update test * update test name * refactor test * sort test order * hardcode endpoints * use session * db_test mark * iterate over app.routes * use fewer endpoints * update comment * update scope (cherry picked from commit 003bf6d) Co-authored-by: Kalyan R <kalyan.ben10@live.com>
kaxil
pushed a commit
that referenced
this pull request
Apr 24, 2025
…n request (#49599) (#49743) * add SimpleAllAdminMiddleware * add tests * update test * update test name * refactor test * sort test order * hardcode endpoints * use session * db_test mark * iterate over app.routes * use fewer endpoints * update comment * update scope (cherry picked from commit 003bf6d) Co-authored-by: Kalyan R <kalyan.ben10@live.com>
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
…n request (apache#49599) * add SimpleAllAdminMiddleware * add tests * update test * update test name * refactor test * sort test order * hardcode endpoints * use session * db_test mark * iterate over app.routes * use fewer endpoints * update comment * update scope
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
…n request (apache#49599) * add SimpleAllAdminMiddleware * add tests * update test * update test name * refactor test * sort test order * hardcode endpoints * use session * db_test mark * iterate over app.routes * use fewer endpoints * update comment * update scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #49453