Remove dag_code records with no serdag #49478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
amoghrajesh,
ashb,
bbovenzi,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil,
o-nikolas,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton,
uranusjr and
vincbeck
as code owners
It is assumed by the migration process that there will not be any dag_code records that don't have a serdag record. It seems this only happens when there are two files with the same dag id.
dstandish
force-pushed
the
fix-upgrade-where-dupe-dag-id
branch
from
2ef1168 to
f5c7664
Compare
dstandish
changed the title
phanikumv
approved these changes
Apr 20, 2025
bugraoz93
approved these changes
Apr 20, 2025
2 tasks
amoghrajesh
approved these changes
Apr 21, 2025
jscheffl
approved these changes
Apr 21, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Same workaround also manually applied and fixed my upgrade issues. As you propose the same I assume the workaround is the final solution.
Contributor
|
Propose to make this to 3.0.1 |
vatsrahul1001
approved these changes
Apr 21, 2025
uranusjr
removed request for
ashb,
bbovenzi,
eladkal,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
kaxil,
o-nikolas,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton,
uranusjr and
vincbeck
uranusjr
force-pushed
the
fix-upgrade-where-dupe-dag-id
branch
from
bb41646 to
ee29672
Compare
kaxil
pushed a commit
that referenced
this pull request
Apr 23, 2025
It is assumed by the migration process that there will not be any dag_code records that don't have a serdag record. It seems this only happens when there are two files with the same dag id. --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 4202418)
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
It is assumed by the migration process that there will not be any dag_code records that don't have a serdag record. It seems this only happens when there are two files with the same dag id. --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate to resolve #49476
Migration from 2.10.5 fails.
The issue occurs when the same DAG exists in two different files. In such cases, the condition dag_code.fileloc_hash = serialized_dag.fileloc_hash fails. As a result, the dag_id column in the dag_code table remains null for that specific DAG, leading to the following error: