Remove duplicate 'mock_supervisor_comms' pytest fixture definitions

[prabhusneha]

Removing the mock_supervisor_comms pytest fixure from -

airflow-core/tests/unit/hooks/test_base.py
airflow-core/tests/unit/models/test_taskinstance.py
airflow-core/tests/conftest.py

as it is already defined in devel-common/src/tests_common/pytest_plugin.py

Created #49520 to delete the definition from providers/openlineage/tests/unit/openlineage/plugins/test_listener.py

[amoghrajesh]

We have a couple more occurrences of this, in:

• airflow-core/tests/conftest.py
• providers/openlineage/tests/unit/openlineage/plugins/test_listener.py (create a seperate PR for this please)

[prabhusneha]

@amoghrajesh These are the locations where mock_supervisor_comms is defined currently in main.

1. airflow-core/tests/conftest.py
2. airflow-core/tests/unit/hooks/test_base.py
3. airflow-core/tests/unit/models/test_taskinstance.py
4. devel-common/src/tests_common/pytest_plugin.py
5. providers/openlineage/tests/unit/openlineage/plugins/test_listener.py

I had initially retained it in 1, so it can be removed from 2 and 3.
Where are you suggesting it be moved for 4 and 5 as well?

[amoghrajesh]

@amoghrajesh These are the locations where mock_supervisor_comms is defined currently in main.

1. airflow-core/tests/conftest.py
2. airflow-core/tests/unit/hooks/test_base.py
3. airflow-core/tests/unit/models/test_taskinstance.py
4. devel-common/src/tests_common/pytest_plugin.py
5. providers/openlineage/tests/unit/openlineage/plugins/test_listener.py

I had initially retained it in 1, so it can be removed from 2 and 3. Where are you suggesting it be moved for 4 and 5 as well?

If we have it in the pytest_plugin.py, it means it can be accessed from anywhere in the codebase. So you should be able to remove every other occurence. For the providers, make a different PR, rest can be in this one

[amoghrajesh]

LGTM +1

[github-actions]

Backport successfully created: v3-0-test

Status	Branch	Result
✅	v3-0-test