Skip to content

Fix mypy for get_oauth_token signature in SnowflakeSqlApiHook #49449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 1 commit into from
Apr 19, 2025
Merged

Fix mypy for get_oauth_token signature in SnowflakeSqlApiHook #49449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def get_headers(self) -> dict[str, Any]:
if all(
[conn_config.get("refresh_token"), conn_config.get("client_id"), conn_config.get("client_secret")]
):
oauth_token = self.get_oauth_token()
oauth_token = self.get_oauth_token(conn_config=conn_config)
headers = {
"Content-Type": "application/json",
"Authorization": f"Bearer {oauth_token}",
Expand Down Expand Up @@ -232,9 +232,8 @@ def get_headers(self) -> dict[str, Any]:
}
return headers

def get_oauth_token(self) -> str:
def get_oauth_token(self, conn_config: dict[str, Any]) -> str:
"""Generate temporary OAuth access token using refresh token in connection details."""
conn_config = self._get_conn_params
url = f"{self.account_identifier}.snowflakecomputing.com/oauth/token-request"
data = {
"grant_type": "refresh_token",
Expand Down
2 changes: 1 addition & 1 deletion providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def test_get_oauth_token(self, mock_conn_param, requests_post, mock_auth):
requests_post.return_value.status_code = 200
mock_auth.return_value = BASIC_AUTH
hook = SnowflakeSqlApiHook(snowflake_conn_id="mock_conn_id")
hook.get_oauth_token()
hook.get_oauth_token(CONN_PARAMS_OAUTH)
requests_post.assert_called_once_with(
f"https://{CONN_PARAMS_OAUTH['account']}.{CONN_PARAMS_OAUTH['region']}.snowflakecomputing.com/oauth/token-request",
data={
Expand Down