Remove logic that patches flask appbuilder etc in core api connections route #49448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun and
rawwar
as code owners
…s route Not sure why this was added, or if it still serves any purpose, but for the core to not depend on flask appbuilder, we can't have code that tries to patch it. Alternative to apache#49446
dstandish
force-pushed
the
remove-fab-dep-from-core-api
branch
from
ec679af to
6928d71
Compare
Member
|
I thin this will prevent the 
|
Member
|
I think we can close this one since, #49446 was merged. Feel free to re-open if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this was added, or if it still serves any purpose, but for the core to not depend on flask appbuilder, we can't have code that tries to patch it.
Alternative to #49446