-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove unused _OPERATOR_EXTRA_LINKS in serialized_objects
#49445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused _OPERATOR_EXTRA_LINKS in serialized_objects
#49445
Conversation
|
Added these links to standard provider section #49447 |
|
In AF2 this is being used part of |
|
Yeah @gopidesupavan thats the reason. Now the operator extra links do not run in the webserver anymore. We push the value generated by |
Thanks yeah, Alright we can cleanup these methods. |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i think we can do this now. Looks fine to me, but would like a second set of eyes too in case we miss something obvious.
fine :) |
fe0532b to
fcc3382
Compare
fcc3382 to
47e8084
Compare
|
Anyone would like to have a look into this? |
|
Could you add a tldr in PR description of What's the problem or if they are unused -- i.e. motivation behind the change |
kaxil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you add PR description, you are good to go :)
_OPERATOR_EXTRA_LINKS in serialized_objects
Yeah added pretty much the understand from the amogh comment i have added there :) |
In AF2 ,
get_operator_extra_linkswas used to get the extra links, and they were handled in webserver. In AF3 a newXComOperatorLinkclass added and extra links are no longer processed in the webserver. Instead when a taks runs, the get_link result is pushed to XCom . The webserver then reads it from the XCom.For plugins defined links, They are converted to XComOperatorLink during deserialization so the webserver can read them too. https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/serialization/serialized_objects.py#L1607
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.