Remove dag_version as a create_dagrun argument #49148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
dstandish
added
the
full tests needed
dstandish
requested review from
XD-DENG,
ashb,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
pierrejeambrun,
potiuk and
rawwar
as code owners
I checked all the uses, and in every case (except one test), either "the latest dag version" was supplied, or None was supplied (in which case, the latest dag version is looked up and used anyway). If we ever need to create a dag run with something other than the latest dag run version, then we can add it back. Having this not be an argument makes it easier to control the behavior at dag run creation time.
dstandish
force-pushed
the
consolidate-dag-version-create-dag-run-behavior
branch
from
65ac9f9 to
5b190dd
Compare
ephraimbuddy
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked all the uses, and in every case (except one test), either "the latest dag version" was supplied, or None was supplied (in which case, the latest dag version is looked up and used anyway).
If we ever need to create a dag run with something other than the latest dag run version, then we can add it back.
Having this not be an argument makes it easier to control the behavior at dag run creation time.