Skip to content

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Apr 11, 2025

#48192 introduced a bug in EksClusterStateSensor. region is specified in the list of templated fields but not saved as attribute which causes:

[2025-04-11 17:18:06,028] {taskinstance.py:2948} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/opt/airflow/task-sdk/src/airflow/sdk/definitions/_internal/abstractoperator.py", line 353, in _do_render_template_fields
    value = getattr(parent, attr_name)
AttributeError: 'EksClusterStateSensor' object has no attribute 'region'

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Apr 11, 2025
Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should have run the system tests on that previous PR :/

@vincbeck vincbeck force-pushed the vincbeck/eks_sensor_region branch 2 times, most recently from 68075fd to 2632865 Compare April 11, 2025 22:21
@vincbeck vincbeck changed the title Fix EksClusterStateSensor. Save region as attribute Fix region parameter in EKS operators/sensors Apr 11, 2025
@vincbeck vincbeck force-pushed the vincbeck/eks_sensor_region branch from 2632865 to ba58290 Compare April 14, 2025 14:13
@vincbeck vincbeck force-pushed the vincbeck/eks_sensor_region branch from ba58290 to a3a0671 Compare April 14, 2025 14:32
@vincbeck vincbeck requested a review from eladkal April 14, 2025 14:55
@vincbeck vincbeck merged commit 20f8af5 into apache:main Apr 14, 2025
65 checks passed
@vincbeck vincbeck deleted the vincbeck/eks_sensor_region branch April 14, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants