Skip to content

Conversation

@guan404ming
Copy link
Member

Why

  • some return type of func is missed in providers

How

  • add the type for them

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@guan404ming guan404ming requested a review from eladkal as a code owner April 11, 2025 16:32
@boring-cyborg boring-cyborg bot added area:providers provider:common-sql provider:google Google (including GCP) related issues labels Apr 11, 2025
@guan404ming guan404ming changed the title type: annotate miss type in provider type: annotate miss return type in provider Apr 11, 2025
@guan404ming guan404ming force-pushed the add-annotation-for-return_single_query_results branch from 923a0c3 to fe36230 Compare April 12, 2025 02:07
@guan404ming guan404ming force-pushed the add-annotation-for-return_single_query_results branch from fe36230 to ee6a803 Compare April 15, 2025 19:19
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amoghrajesh
Copy link
Contributor

@eladkal you ok with this one?

@potiuk potiuk merged commit 098ed33 into apache:main Apr 16, 2025
65 checks passed
@guan404ming guan404ming changed the title type: annotate miss return type in provider Add missing return type in provider Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:common-sql provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants